fix(editor): guard door segment columnRatios against undefined#303
Open
anton-pascal wants to merge 1 commit into
Open
fix(editor): guard door segment columnRatios against undefined#303anton-pascal wants to merge 1 commit into
anton-pascal wants to merge 1 commit into
Conversation
Add defensive null guards for seg.columnRatios and seg.dividerThickness in addLeafSegmentContent(). Legacy door nodes stored in the database may lack these fields since they were added later to the Zod schema with defaults. Without the guard, accessing .length on undefined crashes the viewer (Sentry EDITOR-AM, 487 events in 1 hour burst).
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sentry issue EDITOR-AM — TypeError:
Cannot read properties of undefined (reading 'length')indoor-system.tsx(487 events in a 1-hour burst).In
addLeafSegmentContent(), the code accessesseg.columnRatios.lengthwithout a null guard. Legacy door nodes in the database may lack thecolumnRatiosfield on segments because it was added later to the Zod schema with a default value ([1]). When the viewer loads these nodes directly from the DB (bypassing Zod parse), the field isundefined.Fix
seg.columnRatios ?? [1](matches Zod default)seg.dividerThickness ?? 0.03(matches Zod default)constvariables used throughout the loop for consistencyVerification
tsc --buildpasses cleanly