Feature/source package rf#6
Open
embtom wants to merge 7 commits into
Open
Conversation
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
embtom
force-pushed
the
feature/source_package_rf
branch
from
f11847f to
34a56df
Compare
… for core functionality
embtom
force-pushed
the
feature/source_package_rf
branch
from
34a56df to
366a27e
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances the packtly-builder pipeline around source package handling (notably pristine-tar workflows), while also improving developer/container ergonomics (fixed-path venv, optional custom CA certs) and updating documentation to match the expanded workflow.
Changes:
- Added/updated Debian source build logic (GitPython-backed repo detection, pristine-tar branch handling) and introduced a focused test suite for this behavior.
- Standardized Poetry/venv behavior in containers and dev tooling (fixed
/opt/venv, Poetry configured not to create per-project venvs). - Improved operational/dev UX: optional corporate CA injection in the base image, VS Code task tweaks, and a significantly expanded README.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Readme.md | Expanded usage docs, pipeline explanation, and CLI options/modes. |
| packtly-builder/tooling/pyproject.toml | Adds GitPython dependency used by updated source build logic. |
| packtly-builder/tooling/poetry.toml | Forces Poetry to install into an existing venv (no auto-created venv). |
| packtly-builder/tooling/packtly_builder_tooling/tests/test_deb_source.py | New tests covering quilt/native logic and git/pristine-tar handling. |
| packtly-builder/tooling/packtly_builder_tooling/parts/deb_source.py | Refactors git operations to GitPython and adds repo caching/helpers. |
| packtly-builder/tooling/packtly_builder_tooling/parts/aptly.py | Minor formatting-only change to connection error raising. |
| packtly-builder/tooling/packtly_builder_tooling/parts/apt.py | Minor formatting-only change in DSC parsing condition. |
| packtly-builder/tooling/justfile | Adjusts prepare flow and removes local Poetry venv config step. |
| packtly-builder/containers/Containerfile | Adds python venv support, fixed-path venv, and optional custom CA cert installation. |
| packtly-builder/containers/conf/ca-certificates/.gitkeep | Documents how to add custom CA certs for image builds. |
| packtly-builder/containers/conf/ca-certificates/.gitignore | Prevents committing actual .crt files. |
| .vscode/tasks.json | Switches to a shell-based just task with explicit working directory. |
| .vscode/settings.json | Updates Python interpreter path to the new fixed venv location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
134
to
+138
| # Restore tracked files the clean target deleted or modified. | ||
| cmd_checkout = [self._git, "-C", str(self._builddir), "checkout", "--", "."] | ||
| run_subprocess(cmd_checkout, self._builddir) | ||
|
|
||
| # Remove untracked and ignored build artifacts (symlinks, binaries, etc.). | ||
| cmd_clean = [self._git, "-C", str(self._builddir), "clean", "-fdx"] | ||
| run_subprocess(cmd_clean, self._builddir) | ||
| repo.git.checkout("--", ".") | ||
| # Remove untracked and ignored build artifacts (symlinks, binaries, etc.), | ||
| # scoped to the build tree so a surrounding repo is never touched. | ||
| repo.git.clean("-fdx", "--", str(self._builddir)) |
Comment on lines
221
to
226
| def _ensure_local_branch(self, branch: str) -> None: | ||
| """Create a local branch tracking origin/<branch> if it only exists remotely. | ||
|
|
||
| After a plain ``git clone`` the pristine-tar data is a remote-tracking | ||
| branch; pristine-tar/gbp operate on the local ``refs/heads`` ref. | ||
| """ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.