MR consolidation research#231
Conversation
e1445f8 to
960bbfd
Compare
960bbfd to
04a6eb8
Compare
TomasTomecek
left a comment
There was a problem hiding this comment.
thank you, very nice research! I stopped reading at 50% because it was getting way too long, sorry 😊
lbarcziova
left a comment
There was a problem hiding this comment.
thanks Maja! I agree to start iterating with approach 1 and decide based on it where to go with it.
|
There is a fairly common backport consolidation case that is not being addressed here (maybe it should be addressed separately but its up to you) and that is some patches either address multiple issues at once ie in a single patch/commit. An example of this would be a commit that addresses multiple CVE fixes either in a single patch or multiple patches. Each of those CVEs would have a separate Jira issue associated (one Jira for each CVE). The agent needs to detect that and
in order for the automation pipeline to pick them up and update everything accordingly further down the line eg testing, errata tool and whatever else is in there. This might be a bit tricky to do but the original commit (the one being backported) would have its own Jira issues listed in commit message "Resolves:/Related:" line/s. Each of the Jira issues listed there can be searched for to find related Jira issues for specific stream the agent is currently backporting to and once all of those are found they can be added to its own commit "Resolves:/Related:" line/s followed by update to the Jira issues themselves as needed. |
Thanks for bringing this up! |
| - Downstream has RHEL-1000, RHEL-2000, RHEL-3000 (one per CVE) | ||
| - Agent triggered on RHEL-1000 should detect RHEL-2000 and RHEL-3000 are siblings | ||
|
|
||
| **Solution**: Automatic triage-time detection that parses upstream commit message, finds related downstream issues, and consolidates into single MR with `Resolves: RHEL-1000, RHEL-2000, RHEL-3000`. |
There was a problem hiding this comment.
The solution would also need to include Jira issue updates for each separate CVE (or non CVE issue for that matter) issue:
- transition each Jira issue to "In Progress" as it is required by the downstream automation.
- add a comment to each Jira issue indicating is part of the backport OR link to related MR.
Under (1) once MR is merged then all related Jira issues will have fixedInBuild field updated and Preliminary Testing set to Requested by the downstream automation pipeline and then once Preliminary Testing is Pass the downstream automation pipeline will transition each issue to Integration and attach it to new or existing errata.
There was a problem hiding this comment.
I will add both points to the doc, thanks!
The rebuild consolidation already comments on all consolidated jira issues, but it does not change the status to "In Progress". @lbarcziova do you think we need to change the behaviour also in the rebuild consolidation? Or should we diverge in this aspect?
There was a problem hiding this comment.
we can do that to be consistent with backport/rebase
Document second consolidation scenario for cases where one upstream patch addresses multiple CVEs. Emphasizes symmetry with existing rebuild consolidation pattern to enable code reuse and consistent UX. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Document critical requirements: 1. Transition ALL consolidated issues to "In Progress" (required by downstream automation) 2. Comment on ALL issues with MR link and consolidation explanation Note current gap in rebuild consolidation (comments but doesn't transition) that should be addressed alongside multi-CVE implementation. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
b853b99 to
4e2efc4
Compare
No description provided.