Skip to content

Pass changelog unmodified, let LogAgent swap the JIRA references#508

Open
antbob wants to merge 1 commit into
packit:mainfrom
antbob:simplify_consistent_changelog
Open

Pass changelog unmodified, let LogAgent swap the JIRA references#508
antbob wants to merge 1 commit into
packit:mainfrom
antbob:simplify_consistent_changelog

Conversation

@antbob
Copy link
Copy Markdown
Collaborator

@antbob antbob commented May 20, 2026

Now the source changelog is passed through unmodified, and the LogAgent is told to only swap the JIRA issue references in Resolves/Related lines. This provides better changelog consistency based on our trials and also simplifies the logic making it less error prone. The downside is that the model can make a mistake when swapping JIRA references (if they are present) but that remains to be seen as so far it has behaved correctly on multiple trials.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the backport agent to stop filtering out 'Resolves' and 'Related' lines from source changelogs and updates the log agent's instructions to replace JIRA references within those lines. Feedback indicates that these changes risk creating malformed changelogs with duplicate or missing 'Resolves' lines when multiple commits are combined, and that JIRA references in descriptive lines may not be correctly handled.

Comment thread ymir/agents/backport_agent.py
Comment thread ymir/agents/log_agent.py Outdated
@antbob antbob marked this pull request as draft May 20, 2026 15:20
@antbob antbob force-pushed the simplify_consistent_changelog branch from 087efd3 to 68e2330 Compare May 21, 2026 15:15
@antbob antbob marked this pull request as ready for review May 21, 2026 15:30
@antbob
Copy link
Copy Markdown
Collaborator Author

antbob commented May 21, 2026

Gemini concerns are mostly correct but we cannot replace random references to Jira issues inside changelog messages as we have no context to do that correctly. In order to do something like that we would need to follow each such reference, analyze it and search for an equivalent or related issue for the target, if any exists at all. This would be over the top and not warranted for this. So any such references should stay as they are ie pointing to their original issues.

For Resolves/Related lines the instructions have been modified slightly to be less vague and ambiguous so that the agent can clearly follow the logic of replacing in this case ie removing the old references and adding new ones. It is possible to have edge/corner cases where the agent can still get confused by the original changelog messaging (as there is no common standard among packages or maintainers so anything goes pretty much) but this can be amended by the human in the loop if required as such cases should be relatively rare in practice.

@antbob antbob force-pushed the simplify_consistent_changelog branch from 68e2330 to 34820ed Compare May 21, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant