Skip to content

feat: Unify how code completion is invoke on objects#17

Open
p-spacek wants to merge 2 commits intomainfrom
feat/completion-modifier-unify-invoke
Open

feat: Unify how code completion is invoke on objects#17
p-spacek wants to merge 2 commits intomainfrom
feat/completion-modifier-unify-invoke

Conversation

@p-spacek
Copy link
Copy Markdown
Owner

@p-spacek p-spacek commented Dec 3, 2021

What does this PR do?

Unify how code completion is invoked on objects

it doesn't matter if there is a space after the colon. Completion auto put space after the colon.
when completion is invoked on the property line:

  1. standard completion for simple types is invoked
  2. whole completion process is invoked with a new line after colon. So it'll behave like completion on object.
  3. join the results
Screen.Recording.2021-12-03.at.09.22.30.mov

What issues does this PR fix or reference?

no ref

Is it tested? How?

add UTs

@p-spacek p-spacek self-assigned this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant