Add unit tests for conductor SONiC BGP/VLAN/Loopback/VRF helpers

[berendt]

Closes #2223.

Adds tests/unit/tasks/conductor/sonic/test_config_generator_bgp_vlan_vrf.py covering the BGP, VLAN, Loopback and VRF helpers in osism/tasks/conductor/sonic/config_generator.py.

Coverage

• _add_bgp_configurations — BGP_NEIGHBOR_AF / BGP_NEIGHBOR for connected interfaces and port channels, plus VLAN-SVI BGP: untagged-member exclusion, direct vs. transfer-role IPv4, switch-to-switch / l2vpn_evpn tag handling, non-default VRF, peer-IP local-addr resolution and peer-IP dedup
• _get_connected_device_for_interface — delegation
• _determine_peer_type — AS-mapping vs. computed ASN, missing primary_ip4, and exception handling
• _add_vlan_configuration — members / VLAN_MEMBER / SVI, unmapped-member warning
• _add_loopback_configuration — Loopback0 BGP_GLOBALS_AF_NETWORK (v4/v6), invalid-IP path
• _get_vrf_info — both naming conventions, per-interface and top-level error paths
• _add_vrf_configuration — VNI/table_id/neither, BGP_GLOBALS deep copy, VXLAN sections, interface/port-channel VRF assignment

Notes

• _add_vlan_configuration does not actually sort members by SONiC name (the issue text says it does); tests assert the real behaviour via an order-independent comparison.
• Log-only branches are asserted via the shared loguru_logs fixture.

Checks

• flake8, python-black green locally
• mypy runs as a separate Zuul job; the file follows the annotation-free SimpleNamespace style of the existing, CI-green SONiC test files
• pytest left to the python-osism-unit-tests Zuul job

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="tests/unit/tasks/conductor/sonic/test_config_generator_bgp_vlan_vrf.py" line_range="758-772" />
<code_context>
+# ---------------------------------------------------------------------------
+
+
+@pytest.fixture
+def vrf_config():
+    return {
+        "VRF": {},
+        "VLAN": {},
+        "VLAN_INTERFACE": {},
+        "BGP_GLOBALS_AF": {},
+        "BGP_GLOBALS_ROUTE_ADVERTISE": {},
+        "BGP_GLOBALS": {},
+        "VXLAN_TUNNEL": {},
+        "VXLAN_EVPN_NVO": {},
+        "VXLAN_TUNNEL_MAP": {},
+        "INTERFACE": {},
+        "PORTCHANNEL_INTERFACE": {},
+    }
+
</code_context>
<issue_to_address>
**suggestion (testing):** Initialize ROUTE_REDISTRIBUTE in vrf_config fixture to make the intent explicit

`TestAddVrfConfiguration.test_vrf_with_vni_full_config` asserts that `"vrfStorage|connected|bgp|ipv4" in vrf_config["ROUTE_REDISTRIBUTE"]`, but the fixture doesn’t define `"ROUTE_REDISTRIBUTE"`. The test currently depends on `_add_vrf_configuration` to create this key. Initializing `"ROUTE_REDISTRIBUTE": {}` in the `vrf_config` fixture would make the test more explicit and its failures less dependent on implementation side effects.

```suggestion
@pytest.fixture
def vrf_config():
    return {
        "VRF": {},
        "VLAN": {},
        "VLAN_INTERFACE": {},
        "BGP_GLOBALS_AF": {},
        "BGP_GLOBALS_ROUTE_ADVERTISE": {},
        "BGP_GLOBALS": {},
        "VXLAN_TUNNEL": {},
        "VXLAN_EVPN_NVO": {},
        "VXLAN_TUNNEL_MAP": {},
        "INTERFACE": {},
        "PORTCHANNEL_INTERFACE": {},
        "ROUTE_REDISTRIBUTE": {},
    }
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}