Fix issues with reseting two-factor authentication in the accounts manager.#2988
Merged
Alex-Jordan merged 1 commit intoMay 27, 2026
Merged
Conversation
somiaj
approved these changes
May 26, 2026
…nager. First there was a typo in the name of the form permission for the reset_2fa form. As a result the permission was never actually checked since if a form does not have a permission in the `FORM_PERMS` has it is assumed that no permission is needed. Also, if a user does not have a password record in the database then don't try to reset the OTP secret. The user doesn't have one anyway, and attempting to access the non-existing database record throws an exception.
drgrice1
force-pushed
the
bugfix/instructor-2fa-reset
branch
from
7cd2c0d to
c70e083
Compare
Alex-Jordan
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First there was a typo in the name of the form permission for the reset_2fa form. As a result the permission was never actually checked since if a form does not have a permission in the
FORM_PERMShas it is assumed that no permission is needed.Also, if a user does not have a password record in the database then don't try to reset the OTP secret. The user doesn't have one anyway, and attempting to access the non-existing database record throws an exception.