Fix an invalid import that is causing warnings.#2987
Merged
Conversation
The `write_log_entry` method is imported from the `WeBWorK::Authen` package in `lib/WeBWorK/ContentGenerator/Logout.pm` (via the `use WeBWorK::Authen qw(write_log_entry)` call). However, the `WeBWorK::Authen` package does not define the `import` method (since it does not derive from the `Exporter` package). As a result warnings occur when this package is loaded. These warnings have become more prevalant recently (perhaps the perl 5.40 is more strict on this?). Also, the `write_log_entry` is incorrectly called later in that package. The `write_log_entry` method is an object method and there is no need for the package name in the call.
drgrice1
force-pushed
the
bugfix/invalid-import
branch
from
9b4a32b to
5061879
Compare
Alex-Jordan
approved these changes
May 27, 2026
somiaj
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
write_log_entrymethod is imported from theWeBWorK::Authenpackage inlib/WeBWorK/ContentGenerator/Logout.pm(via theuse WeBWorK::Authen qw(write_log_entry)call). However, theWeBWorK::Authenpackage does not define theimportmethod (since it does not derive from theExporterpackage). As a result warnings occur when this package is loaded. These warnings have become more prevalant recently (perhaps the perl 5.40 is more strict on this?).Also, the
write_log_entryis incorrectly called later in that package. Thewrite_log_entrymethod is an object method and there is no need for the package name in the call.