fix for splitted utf-8 signs, based on genai solution#4284
Open
przepeck wants to merge 2 commits into
Open
Conversation
dkalinowski
reviewed
Jun 11, 2026
|
|
||
| // 1. Newline flush: emit everything and reset. | ||
| if (!text.empty() && text.back() == '\n' && text.size() > m_printed_len) { | ||
| const auto status = flush_chunk(text, text.size(), ov::genai::GenerationFinishReason::NONE); |
Collaborator
There was a problem hiding this comment.
In GenAI it is cut (- m_printed_len):
res << std::string_view{text.data() + m_printed_len, text.size() - m_printed_len};
https://github.com/openvinotoolkit/openvino.genai/blob/master/src/cpp/src/text_streamer.cpp#L36
Collaborator
Author
There was a problem hiding this comment.
it's done in flush_chunk, lines 163-168
dkalinowski
reviewed
Jun 11, 2026
dkalinowski
reviewed
Jun 11, 2026
| if (n < DELAY_N_TOKENS) { | ||
| return ov::genai::StreamingStatus::RUNNING; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
dont we also need compute_decoded_length_for_position from genai?
Collaborator
Author
There was a problem hiding this comment.
I didn't want to interfere in Miłosz's PR that much. I belived he had reasons not to copy genai's TextStreamer 1:1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
🧪 Checklist
``