Skip to content

Fix client IP logging in Watcher API VirtualHost#398

Open
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:customlog
Open

Fix client IP logging in Watcher API VirtualHost#398
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:customlog

Conversation

@fmount

@fmount fmount commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Align watcher httpd logging with the existing operator pattern:

  • Add missing SetEnvIf X-Forwarded-For in the VirtualHost block
  • Normalize server-level httpd.conf: use the existing pattern for LogFormat names (combined, proxy), and log to /dev/stdout so logs are visible via oc logs -f

Related: OSPRH-32126

@fmount @claude
Fix client IP logging in Watcher API VirtualHost
032ea3b 
Align watcher httpd logging with the cinder/nova-operator pattern:
- Add missing SetEnvIf X-Forwarded-For in the VirtualHost block
- Normalize server-level httpd.conf: use standard LogFormat names
  (combined, proxy), fix inverted env= on proxy CustomLog, log to
  /dev/stdout so logs are visible via oc logs -f

Closes: OSPRH-32126

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount requested a review from amoralej July 2, 2026 09:50
@openshift-ci openshift-ci Bot requested review from abays and cescgina July 2, 2026 09:50
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Jul 2, 2026

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/56a08f5b000e496189e7a8e810dd2520

✔️ openstack-meta-content-provider-master SUCCESS in 3h 08m 14s
❌ watcher-operator-validation-master FAILURE in 2h 20m 15s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 28m 38s
❌ watcher-operator-validation-epoxy FAILURE in 1h 57m 28s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 2h 07m 59s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 54m 35s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoralej amoralej Awaiting requested review from amoralej
@abays abays Awaiting requested review from abays
@cescgina cescgina Awaiting requested review from cescgina

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fmount