Skip to content

Add capi-tests suite to JUnit import allowlist#3697

Open
RadekCap wants to merge 1 commit into
openshift:mainfrom
RadekCap:add-capi-tests-suite
Open

Add capi-tests suite to JUnit import allowlist#3697
RadekCap wants to merge 1 commit into
openshift:mainfrom
RadekCap:add-capi-tests-suite

Conversation

@RadekCap

@RadekCap RadekCap commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add github.com/stolostron/capi-tests/test to the test suites allowlist so Sippy can import JUnit test results from the capi-qe release

The capi-qe release is already configured in openshift-customizations.yaml with the job periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e, but test results are silently skipped because the suite name is not in the testSuites allowlist in pkg/db/suites.go.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Added support for importing an additional test suite during database setup, so it can now be recognized and loaded automatically.

The capi-qe release is already configured with the job
periodic-ci-stolostron-capi-tests-configure-prow-mgmt-periodics-capz-e2e,
but test results are silently skipped because the suite name
github.com/stolostron/capi-tests/test is not in the testSuites allowlist.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 92227f50-0086-45b3-862f-abbef8958beb

📥 Commits

Reviewing files that changed from the base of the PR and between 17ff10d and 92eb89c.

📒 Files selected for processing (1)
  • pkg/db/suites.go

Walkthrough

The explicit test-suite allowlist was expanded to include github.com/stolostron/capi-tests/test, so DB suite import setup now treats that suite as importable.

Changes

Test suite allowlist update

Layer / File(s) Summary
Allowlist entry
pkg/db/suites.go
The testSuites explicit allowlist adds github.com/stolostron/capi-tests/test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

approved, lgtm, ready-for-human-review

Suggested reviewers

  • deepsm007
  • sosiouxme
  • neisw
🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes adding the capi-tests suite to the JUnit import allowlist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PASS: The PR only adds an allowlisted suite string; no error-handling paths were changed or introduced.
Sql Injection Prevention ✅ Passed The PR only adds a literal suite name to an allowlist; the related DB lookup already uses a parameterized Where("name = ?", name) query.
Excessive Css In React Should Use Styles ✅ Passed PR only edits pkg/db/suites.go to add a test-suite allowlist entry; no React components or inline styles are involved.
Test Coverage For New Features ✅ Passed The PR only adds one suite name to an existing allowlist; no new code paths or functions were introduced, so this config-only/data change doesn’t need extra tests.
Single Responsibility And Clear Naming ✅ Passed The PR only adds one explicit suite name to an existing allowlist; it introduces no new packages, structs, methods, or unclear names.
Feature Documentation ✅ Passed No feature doc covers suite-import allowlists; the only docs/features page is about job-analysis symptoms, so this code tweak didn’t need doc changes.
Stable And Deterministic Test Names ✅ Passed No test titles were added or changed; the patch only updates a suite allowlist in pkg/db/suites.go and contains no Ginkgo It/Describe/Context/When calls.
Test Structure And Quality ✅ Passed Only change is adding one allowlisted suite name in pkg/db/suites.go; no Ginkgo tests or assertions were modified, so this quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only updates the JUnit suite allowlist in pkg/db/suites.go.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only adds a suite name to a DB allowlist; it introduces no new Ginkgo tests or node-topology assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only a JUnit suite allowlist entry was added in pkg/db/suites.go; no manifests, controllers, replicas, affinity, taints, or node selectors were changed.
Ote Binary Stdout Contract ✅ Passed Only adds an allowlist string in pkg/db/suites.go; no process-level stdout writes or logging changes are present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: This PR only adds a suite name to the DB allowlist; no new Ginkgo tests, IPv4 assumptions, or external connectivity were introduced.
No-Weak-Crypto ✅ Passed PR only adds a suite name to an allowlist in pkg/db/suites.go; no crypto primitives, custom crypto, or secret/token comparisons are introduced.
Container-Privileges ✅ Passed PASS: The PR only adds a suite name in pkg/db/suites.go; no container/K8s manifests or privileged settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed One-line allowlist addition only; no new logs or sensitive fields were introduced, and existing logs only emit suite names/errors.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 25, 2026
@RadekCap

Copy link
Copy Markdown
Contributor Author

AI Review Pipeline Summary

Category Details
Self-Review 0 findings
Security Review 0 findings (static allowlist entry)
CodeRabbit 1 round, 0 findings
Pre-merge Checks 0 failures
Qodo 0 findings

No issues found across all review stages. The change is a single-line addition to a static string slice — correct syntax, logical placement in the ARO section, and no security surface.


🤖 Generated by /ai-review pipeline

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@RadekCap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marek-veber marek-veber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2026
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marek-veber, RadekCap
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RadekCap

Copy link
Copy Markdown
Contributor Author

/assign deads2k

@RadekCap

Copy link
Copy Markdown
Contributor Author

@deads2k could you /approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants