[WIP] DO NOT MERGE - testing haproxy rpm build version

[gcs278]

a quick PR to fail the images job so we can see what RPM is getting installed quickly.

Summary by CodeRabbit

• Chores
  • Modified router HAProxy image build configuration, which will now fail during the initialization step.

[gcs278]

/test images

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Walkthrough

A single RUN exit 1 instruction is added to images/router/haproxy/Dockerfile.ocp immediately after the WORKDIR /var/lib/haproxy/conf line, unconditionally terminating the Docker image build with a failure exit code at that step.

Changes

Intentional Dockerfile build failure

Layer / File(s)	Summary
RUN exit 1 inserted into Dockerfile.ocp images/router/haproxy/Dockerfile.ocp	Adds a RUN exit 1 layer after WORKDIR /var/lib/haproxy/conf, causing the OCP haproxy router image build to fail unconditionally at that point.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[WIP] DO NOT MERGE - testing haproxy rpm build version' accurately describes the PR's purpose as a work-in-progress diagnostic test to verify RPM versions during the build process.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR modifies only a Dockerfile (images/router/haproxy/Dockerfile.ocp), which is infrastructure/build configuration, not test code. The check for stable test names is not applicable to this PR s...
Test Structure And Quality	✅ Passed	The custom check for Ginkgo test code quality does not apply to this PR, which only modifies a Dockerfile and contains no test code changes.
Microshift Test Compatibility	✅ Passed	PR modifies only a Dockerfile (images/router/haproxy/Dockerfile.ocp), not Ginkgo e2e tests. MicroShift compatibility check applies only to new e2e tests, making it not applicable here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The check explicitly applies only when "new Ginkgo e2e tests are added," and all test files use the standard Go testing package, not Ginkgo.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only modifies a Dockerfile (adding RUN exit 1), not deployment manifests, operator code, or controllers. Dockerfile changes cannot introduce Kubernetes scheduling constraints, so this topolo...
Ote Binary Stdout Contract	✅ Passed	The custom check for "OTE Binary Stdout Contract" is not applicable to this PR. The PR only modifies a Dockerfile (images/router/haproxy/Dockerfile.ocp) and contains no Go code, test code, or OTE b...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies a Dockerfile, not Ginkgo e2e tests. The custom check targets e2e test IPv6/disconnected compatibility, which is not applicable here.
No-Weak-Crypto	✅ Passed	PR only adds a Docker RUN instruction and contains no cryptographic code, making the weak-crypto check not applicable.
Container-Privileges	✅ Passed	PR only adds temporary RUN exit 1 diagnostic line to Dockerfile; no security context, privileged, hostPID/Network/IPC, or allowPrivilegeEscalation configurations are introduced or modified.
No-Sensitive-Data-In-Logs	✅ Passed	The change adds only RUN exit 1 to fail the build intentionally; no logging of sensitive data like passwords, tokens, API keys, PII, or other confidential information is introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgreene570 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@images/router/haproxy/Dockerfile.ocp`:
- Line 20: The Dockerfile contains an unconditional build failure command `RUN
exit 1` that prevents any image builds from completing successfully. Remove this
`RUN exit 1` line from the Dockerfile entirely to allow the build pipeline to
proceed normally.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bfab6d7f-fc99-4d42-92a5-31b6a12c12eb

📥 Commits

Reviewing files that changed from the base of the PR and between 3553702 and db24171.

📒 Files selected for processing (1)

• images/router/haproxy/Dockerfile.ocp

[coderabbitai]

🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Remove the unconditional build breaker before merge.

Line 20 (RUN exit 1) guarantees a non-zero exit, so every build that consumes this Dockerfile fails. Given the Makefile target builds from images/router/*/Dockerfile.ocp, this blocks the OCP router image pipeline entirely.

Suggested fix

 WORKDIR /var/lib/haproxy/conf
-RUN exit 1
 ENV TEMPLATE_FILE=/var/lib/haproxy/conf/haproxy-config.template \
     RELOAD_SCRIPT=/var/lib/haproxy/reload-haproxy

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@images/router/haproxy/Dockerfile.ocp` at line 20, The Dockerfile contains an
unconditional build failure command `RUN exit 1` that prevents any image builds
from completing successfully. Remove this `RUN exit 1` line from the Dockerfile
entirely to allow the build pipeline to proceed normally.

[openshift-ci]

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	db24171	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.