Skip to content

Adding three job profiles for migrating ipfailover test cases #81103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvinjoseph86 wants to merge 1 commit into from
Closed

Adding three job profiles for migrating ipfailover test cases #81103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions ci-operator/config/openshift/images/openshift-images-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,71 @@ tests:
steps:
cluster_profile: equinix-ocp-metal
workflow: baremetalds-e2e-ovn-ipv6
- as: tests-extension
run_if_changed: ^(tests-extension/)
steps:
test:
- as: sanity
commands: |
cd tests-extension
make verify
make build
make verify-metadata
from: src
resources:
requests:
cpu: 100m
- always_run: false
as: e2e-metal-ipi-tests-ext
optional: true
steps:
cluster_profile: equinix-ocp-metal
test:
- as: test
cli: latest
commands: |
cd tests-extension
make build
./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1
from: src
resources:
requests:
cpu: 100m
workflow: baremetalds-e2e-ovn-ipv4
- always_run: false
as: e2e-openstack-ipi-tests-ext
optional: true
steps:
cluster_profile: openstack-vexxhost
test:
- as: test
cli: latest
commands: |
cd tests-extension
make build
./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1
from: src
resources:
requests:
cpu: 100m
workflow: openshift-e2e-openstack-ipi
- always_run: false
as: e2e-vsphere-ovn-tests-ext
optional: true
steps:
cluster_profile: vsphere-elastic
test:
- as: test
cli: latest
commands: |
cd tests-extension
make build
./bin/ipfailover-tests-ext run-suite ipfailover/all --max-concurrency=1
from: src
resources:
requests:
cpu: 100m
workflow: openshift-e2e-vsphere-ovn
Comment on lines +58 to +122

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Checking for generated Prow job files for openshift/images..."
fd -p 'openshift-images.*\.yaml$' ci-operator/jobs/

echo
echo "Looking for the newly added job names in generated job configs..."
rg -n -C2 'tests-extension|e2e-metal-ipi-tests-ext|e2e-openstack-ipi-tests-ext|e2e-vsphere-ovn-tests-ext' ci-operator/jobs/

Repository: openshift/release

Length of output: 50374

Regenerate and include downstream Prow job artifacts.
The modified config file ci-operator/config/openshift/images/openshift-images-master.yaml adds four new tests (tests-extension, e2e-metal-ipi-tests-ext, e2e-openstack-ipi-tests-ext, e2e-vsphere-ovn-tests-ext), but the corresponding generated files in ci-operator/jobs/openshift/images/ do not contain these new job definitions.

Run make update to regenerate the Prow job configuration files and commit the resulting changes to ci-operator/jobs/.
[classify_review_comment]

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/config/openshift/images/openshift-images-master.yaml` around
lines 58 - 122, The openshift-images-master config now defines new jobs, but the
generated downstream Prow job artifacts were not updated. Regenerate the job
configs with make update so the new entries from the config are reflected in the
files under ci-operator/jobs/openshift/images/, and commit those generated
changes alongside the config update.

Sources: Coding guidelines, Learnings

- as: verify-deps
steps:
env:
Expand Down
Loading