Add GCD cluster profile#80743
Conversation
Add the "gcd" (Google Cloud Dedicated) cluster profile for testing OpenShift installations on Google Cloud Dedicated (Berlin environment) using Workload Identity Federation. - Register "gcd" cluster profile with cluster_type "gcp" - Add cluster-secrets-gcd to secret bootstrap config - Add 3 Boskos quota slices for gcd-quota-slice - Add e2e-gcd test to installer config, pinned to build13 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughA new Changesgcd Cluster Profile Registration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@rochacbruno, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
The region prefix in Boskos slice names becomes LEASED_RESOURCE, which install steps pass as the target region. Use europe-west3 to match the valid GCD regions from the installer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@rochacbruno, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
I wonder if we should scope this PR to just adding the cluster-profile. We can add the installer CI job in a follow-up 🤔 WDYT? |
|
@tthvo Good point. The CI tests are failing because the ci-tools PR (openshift/ci-tools#5261) needs to merge first to register the I'll split this into two PRs:
Will push an update shortly. |
Scope this PR to cluster profile registration only. The e2e-gcd installer job will be added in a follow-up PR once the profile is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rochacbruno The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Storage team needs access for CSI operator testing on GCD, same as the AWS EUSC pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@rochacbruno: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Summary
gcd(Google Cloud Dedicated) cluster profile withcluster_type: gcp, owned byopenshift/installercluster-secrets-gcdto secret bootstrap config (distributed tonon_app_ciclusters)gcd-quota-slice(regioneurope-west3)The installer CI job (
e2e-gcd) will be added in a follow-up PR once the profile is registered.Context
Part of CORS-4508: setting up Workload Identity Federation authentication for the OpenShift installer on Google Cloud Dedicated (Berlin environment).
Companion PRs
ClusterProfileGCDinclusterprofile.go(must merge first)Test plan
cluster-secrets-gcdis populated with WIF credential confige2e-gcdinstaller jobGenerated with Claude Code
Summary by CodeRabbit
This PR establishes infrastructure support for the GCD (Google Cloud Dedicated) cluster profile, enabling OpenShift installer testing on Google Cloud Dedicated's Berlin environment using Workload Identity Federation authentication.
Infrastructure Changes:
Cluster Profile Registration (
cluster-profiles-config.yaml): Added a newgcdcluster profile configured for GCP with ownership assigned to both theopenshift/installerandcsi-operatorteams, making it available for CI jobs targeting this testing environment.Secret Distribution (
ci-secret-bootstrap/_config.yaml): Integratedcluster-secrets-gcdinto the secret bootstrap configuration to distribute credentials tonon_app_ciclusters, ensuring proper credential management for the new profile.Resource Quotas (
_boskos.yaml): Added three Boskos quota slices forgcd-quota-slicein theeurope-west3region to manage resource allocation for GCD cluster provisioning.Scope: This PR focuses exclusively on cluster profile registration and infrastructure setup. The corresponding
e2e-gcdinstaller CI job will be added in a follow-up PR once the profile becomes available in the system (dependent on openshift/ci-tools#5261).