Skip to content

Omit Node Info rendering for 4.18 and earlier#787

Draft
sdodson wants to merge 1 commit into
openshift:mainfrom
sdodson:omit-node-info-4.18-and-earlier
Draft

Omit Node Info rendering for 4.18 and earlier#787
sdodson wants to merge 1 commit into
openshift:mainfrom
sdodson:omit-node-info-4.18-and-earlier

Conversation

@sdodson

@sdodson sdodson commented Jun 29, 2026

Copy link
Copy Markdown
Member

rpmdb collection on 4.18 and earlier requires pulling the entire rhel-coreos image. 4.19+ stores the rpmdb separately, making it significantly cheaper.

Changes

Adds ReleaseTagHasCheapRpmdb() to pkg/release-controller/semver.go, which returns false for 4.x tags where x <= 18. Unparseable tags (nightlies, CI builds) are not gated.

Uses the new function to skip Node Info in three places:

  • getChangeLog() / renderChangeLog() — HTML page and compare page
  • apiReleaseInfo() — API endpoint (/api/v1/releasestream/{release}/release/{tag})

For gated releases the API response will have a null nodeImageStreams field, which is already a valid state. The #node-image-info anchor links that oc may emit in the changelog body for older releases are left as dead anchors for now.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9c9f0620-3cdf-499a-9e91-987f3288f6ff

📥 Commits

Reviewing files that changed from the base of the PR and between 3e9a804 and 2c4a1ea.

📒 Files selected for processing (3)
  • cmd/release-controller-api/http.go
  • cmd/release-controller-api/http_changelog.go
  • pkg/release-controller/semver.go
 ___________________________________________________________
< Your API returns 200 OK; your users return 404 Not Found. >
 -----------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdodson
Once this PR has been reviewed and has the lgtm label, please assign jupierce for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson force-pushed the omit-node-info-4.18-and-earlier branch from fc9903f to 8b72ac6 Compare June 30, 2026 02:45
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2026
rpmdb collection on 4.18 and earlier requires pulling the entire
rhel-coreos image. 4.19+ stores the rpmdb separately, making it
significantly cheaper.

Add ReleaseTagHasCheapRpmdb() which returns false for 4.x tags
where x <= 18, and use it to skip Node Info in:
- getChangeLog() / renderChangeLog() (HTML page and compare page)
- apiReleaseInfo() (API endpoint)

Unparseable tags (nightlies, CI builds) are not gated.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@sdodson sdodson force-pushed the omit-node-info-4.18-and-earlier branch from 8b72ac6 to 2c4a1ea Compare June 30, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant