Omit Node Info rendering for 4.18 and earlier#787
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fc9903f to
8b72ac6
Compare
rpmdb collection on 4.18 and earlier requires pulling the entire rhel-coreos image. 4.19+ stores the rpmdb separately, making it significantly cheaper. Add ReleaseTagHasCheapRpmdb() which returns false for 4.x tags where x <= 18, and use it to skip Node Info in: - getChangeLog() / renderChangeLog() (HTML page and compare page) - apiReleaseInfo() (API endpoint) Unparseable tags (nightlies, CI builds) are not gated. rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
8b72ac6 to
2c4a1ea
Compare
rpmdb collection on 4.18 and earlier requires pulling the entire
rhel-coreosimage. 4.19+ stores the rpmdb separately, making it significantly cheaper.Changes
Adds
ReleaseTagHasCheapRpmdb()topkg/release-controller/semver.go, which returnsfalsefor4.xtags wherex <= 18. Unparseable tags (nightlies, CI builds) are not gated.Uses the new function to skip Node Info in three places:
getChangeLog()/renderChangeLog()— HTML page and compare pageapiReleaseInfo()— API endpoint (/api/v1/releasestream/{release}/release/{tag})For gated releases the API response will have a null
nodeImageStreamsfield, which is already a valid state. The#node-image-infoanchor links thatocmay emit in the changelog body for older releases are left as dead anchors for now.