Skip to content

Commit 6ecd806

Browse files
wangke19openshift-cherrypick-robot
authored andcommitted
cert tests: mark TLS certificate tests as informing
Add ote.Informing() to both certificate tests so that failures are recorded but don't block CI jobs: - all tls artifacts must be registered - all registered tls artifacts must have no metadata violation regressions This allows the tests to continue gathering data without blocking development while certificates are being properly registered and metadata is being fixed.
1 parent 4e7db01 commit 6ecd806

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

test/extended/operators/certs.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626

2727
g "github.com/onsi/ginkgo/v2"
2828
o "github.com/onsi/gomega"
29+
ote "github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo"
2930

3031
"github.com/openshift/library-go/pkg/certs/cert-inspection/certgraphanalysis"
3132
"github.com/openshift/library-go/pkg/certs/cert-inspection/certgraphapi"
@@ -175,7 +176,7 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
175176
o.Expect(err).NotTo(o.HaveOccurred())
176177
})
177178

178-
g.It("all tls artifacts must be registered", func() {
179+
g.It("all tls artifacts must be registered", ote.Informing(), func() {
179180
violationsPKIContent, err := certs.GetPKIInfoFromEmbeddedOwnership(ownership.PKIViolations)
180181
o.Expect(err).NotTo(o.HaveOccurred())
181182

@@ -282,19 +283,13 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
282283
}
283284
})
284285

285-
g.It("all registered tls artifacts must have no metadata violation regressions", func() {
286+
g.It("all registered tls artifacts must have no metadata violation regressions", ote.Informing(), func() {
286287
violationRegressionOptions := ensure_no_violation_regression.NewEnsureNoViolationRegressionOptions(ownership.AllViolations, genericclioptions.NewTestIOStreamsDiscard())
287288
messages, _, err := violationRegressionOptions.HaveViolationsRegressed([]*certgraphapi.PKIList{actualPKIContent})
288289
o.Expect(err).NotTo(o.HaveOccurred())
289290

290291
if len(messages) > 0 {
291-
<<<<<<< HEAD
292-
// TODO: uncomment when test no longer fails and enhancement is merged
293-
// g.Fail(strings.Join(messages, "\n"))
294292
testresult.Flakef("%s", strings.Join(messages, "\n"))
295-
=======
296-
g.Fail(strings.Join(messages, "\n"))
297-
>>>>>>> 1e1a521985 (Reapply "OCPBUGS-60853: make TLS registry tests required")
298293
}
299294
})
300295

0 commit comments

Comments
 (0)