Skip to content

Commit 4e7db01

Browse files
wangke19openshift-cherrypick-robot
authored andcommitted
Reapply "OCPBUGS-60853: make TLS registry tests required"
This reverts commit 714b0f2.
1 parent 6708c95 commit 4e7db01

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

test/extended/operators/certs.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -276,11 +276,8 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
276276
if len(newTLSRegistry.CertKeyPairs) > 0 || len(newTLSRegistry.CertificateAuthorityBundles) > 0 {
277277
registryString, err := json.MarshalIndent(newTLSRegistry, "", " ")
278278
if err != nil {
279-
// g.Fail("Failed to marshal registry %#v: %v", newTLSRegistry, err)
280279
testresult.Flakef("Failed to marshal registry %#v: %v", newTLSRegistry, err)
281280
}
282-
// TODO: uncomment when test no longer fails and enhancement is merged
283-
// g.Fail(fmt.Sprintf("Unregistered TLS certificates:\n%s", registryString))
284281
testresult.Flakef("Unregistered TLS certificates found:\n%s\nSee tls/ownership/README.md in origin repo", registryString)
285282
}
286283
})
@@ -291,9 +288,13 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
291288
o.Expect(err).NotTo(o.HaveOccurred())
292289

293290
if len(messages) > 0 {
291+
<<<<<<< HEAD
294292
// TODO: uncomment when test no longer fails and enhancement is merged
295293
// g.Fail(strings.Join(messages, "\n"))
296294
testresult.Flakef("%s", strings.Join(messages, "\n"))
295+
=======
296+
g.Fail(strings.Join(messages, "\n"))
297+
>>>>>>> 1e1a521985 (Reapply "OCPBUGS-60853: make TLS registry tests required")
297298
}
298299
})
299300

0 commit comments

Comments
 (0)