Merge pull request #22794 from sanchezl/e2e_do_not_check_file_size

openshift-merge-robot · web-flow · commit 34f13a8d3f46 · 2019-05-09T23:02:35.000+02:00
Revert "e2e must-gather disable check for file sizes"
diff --git a/test/extended/cli/mustgather.go b/test/extended/cli/mustgather.go
@@ -70,7 +70,7 @@ var _ = g.Describe("[cli] oc adm must-gather", func() {
 			}
 		}
 		if len(emptyFiles) > 0 {
-			fmt.Printf("expected files should not be empty: \n%s", strings.Join(emptyFiles, "\n"))
+			o.Expect(fmt.Errorf("expected files should not be empty: %s", strings.Join(emptyFiles, ","))).NotTo(o.HaveOccurred())
 		}
 
 	})

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ var _ = g.Describe("[cli] oc adm must-gather", func() {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`if len(emptyFiles) > 0 {`
`73`		`- fmt.Printf("expected files should not be empty: \n%s", strings.Join(emptyFiles, "\n"))`
	`73`	`+ o.Expect(fmt.Errorf("expected files should not be empty: %s", strings.Join(emptyFiles, ","))).NotTo(o.HaveOccurred())`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`})`