Skip to content

Commit 4fa6833

Browse files
Merge pull request #22793 from coreydaley/bugzilla_1704767_update_s2i_incremental_test
Bug 1704767: Update tests for S2I incremental builds
2 parents 4b54010 + feac91c commit 4fa6833

3 files changed

Lines changed: 11 additions & 99 deletions

File tree

test/extended/builds/s2i_incremental.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ var _ = g.Describe("[Feature:Builds][Slow] incremental s2i build", func() {
4848
o.Expect(err).NotTo(o.HaveOccurred())
4949

5050
g.By("starting a test build")
51-
br, _ := exutil.StartBuildAndWait(oc, "initial-build")
51+
br, _ := exutil.StartBuildAndWait(oc, "incremental-build")
5252
br.AssertSuccess()
5353

5454
g.By("starting a test build using the image produced by the last build")
55-
br2, _ := exutil.StartBuildAndWait(oc, "internal-build")
55+
br2, _ := exutil.StartBuildAndWait(oc, "incremental-build")
5656
br2.AssertSuccess()
5757

5858
g.By("getting the Docker image reference from ImageStream")
59-
imageName, err := exutil.GetDockerImageReference(oc.ImageClient().Image().ImageStreams(oc.Namespace()), "internal-image", "latest")
59+
imageName, err := exutil.GetDockerImageReference(oc.ImageClient().Image().ImageStreams(oc.Namespace()), "incremental-image", "latest")
6060
o.Expect(err).NotTo(o.HaveOccurred())
6161

6262
g.By("instantiating a pod and service with the new image")

test/extended/testdata/bindata.go

Lines changed: 4 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/extended/testdata/builds/incremental-auth-build.json

Lines changed: 4 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"kind": "ImageStream",
1616
"apiVersion": "v1",
1717
"metadata": {
18-
"name": "internal-image",
18+
"name": "incremental-image",
1919
"creationTimestamp": null
2020
},
2121
"spec": {}
@@ -24,10 +24,10 @@
2424
"kind": "BuildConfig",
2525
"apiVersion": "v1",
2626
"metadata": {
27-
"name": "initial-build",
27+
"name": "incremental-build",
2828
"creationTimestamp": null,
2929
"labels": {
30-
"name": "initial-build"
30+
"name": "incremental-build"
3131
}
3232
},
3333
"spec": {
@@ -49,58 +49,14 @@
4949
"from": {
5050
"kind": "DockerImage",
5151
"name": "centos/ruby-22-centos7:latest"
52-
}
53-
}
54-
},
55-
"output": {
56-
"to": {
57-
"kind": "ImageStreamTag",
58-
"name": "internal-image:latest"
59-
}
60-
},
61-
"resources": {}
62-
},
63-
"status": {
64-
"lastVersion": 0
65-
}
66-
},
67-
{
68-
"kind": "BuildConfig",
69-
"apiVersion": "v1",
70-
"metadata": {
71-
"name": "internal-build",
72-
"creationTimestamp": null,
73-
"labels": {
74-
"name": "internal-build"
75-
}
76-
},
77-
"spec": {
78-
"source": {
79-
"type": "Git",
80-
"git": {
81-
"uri": "https://github.com/openshift/incremental-app.git"
82-
}
83-
},
84-
"strategy": {
85-
"type": "Source",
86-
"sourceStrategy": {
87-
"env": [
88-
{
89-
"name": "BUILD_LOGLEVEL",
90-
"value": "5"
91-
}
92-
],
93-
"from": {
94-
"kind": "ImageStreamTag",
95-
"name": "internal-image:latest"
9652
},
9753
"incremental": true
9854
}
9955
},
10056
"output": {
10157
"to": {
10258
"kind": "ImageStreamTag",
103-
"name": "internal-image:latest"
59+
"name": "incremental-image:latest"
10460
}
10561
}
10662
}

0 commit comments

Comments
 (0)