Rosaeng 60410 bump ubi image#246
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tkong-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis PR updates CI and lint configuration, bumps Go and container dependencies, adjusts test constants and webhook expectations, and removes members from two OWNERS alias lists. ChangesRepository maintenance updates
Estimated review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings)
✅ Passed checks (12 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
build/Dockerfile (1)
10-10: 🔒 Security & Privacy | 🔵 Trivial | 💤 Low valueConsider a floating tag for the Red Hat base image.
This pins
ubi-minimalto a specific build (9.8-1782191395). Red Hat manages updates (CVE patches) on floating tags such as9.8, so a floating tag lets you pick up security fixes automatically without a manual bump. If reproducibility is the intent here, that's a valid tradeoff—just confirm it's deliberate.As per path instructions: "Red Hat images: use floating tags (Red Hat manages updates); non-RH images: pin by digest".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@build/Dockerfile` at line 10, The Docker base image is pinned to a specific Red Hat build instead of using the intended floating tag. Update the FROM reference in the Dockerfile to use the floating ubi-minimal tag managed by Red Hat, and keep any version pinning only if reproducibility is explicitly required. Use the existing base image reference to locate the change.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 119: The Kubernetes dependency set is mixed across minor versions, with
k8s.io/apiextensions-apiserver still on the older 0.33 line while the rest of
the core k8s.io/* modules are on 0.35.2. Update the module versions in go.mod as
a coordinated set so the Kubernetes stack stays on one minor line, and verify
any controller-runtime-related transitive pulls are aligned as part of the same
dependency refresh rather than changing k8s.io/apiextensions-apiserver alone.
---
Nitpick comments:
In `@build/Dockerfile`:
- Line 10: The Docker base image is pinned to a specific Red Hat build instead
of using the intended floating tag. Update the FROM reference in the Dockerfile
to use the floating ubi-minimal tag managed by Red Hat, and keep any version
pinning only if reproducibility is explicitly required. Use the existing base
image reference to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8b371679-d746-4e46-a900-498a7170df10
⛔ Files ignored due to path filters (5)
boilerplate/_data/backing-image-tagis excluded by!boilerplate/**boilerplate/_data/last-boilerplate-commitis excluded by!boilerplate/**boilerplate/openshift/golang-osd-e2e/updateis excluded by!boilerplate/**boilerplate/openshift/osd-container-image/OWNERS_ALIASESis excluded by!boilerplate/**go.sumis excluded by!**/*.sum
📒 Files selected for processing (11)
.ci-operator.yaml.github/renovate.json.golangci.ymlMakefileOWNERS_ALIASESbuild/Dockerfilego.modpkg/consts/test/test.gopkg/handlers/webhookreceiver_test.gopkg/handlers/webhookrhobsreceiver_test.gotest/e2e/Dockerfile
💤 Files with no reviewable changes (1)
- OWNERS_ALIASES
|
@tkong-redhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 55.67% 55.67%
=======================================
Files 23 23
Lines 1895 1895
=======================================
Hits 1055 1055
Misses 785 785
Partials 55 55
🚀 New features to boost your workflow:
|
2 participants
Rosaeng 60410 bump ubi image for testing pipeline.
Code has been tested
Summary by CodeRabbit