e2e: fix label-filter shell quoting in test-e2e target

[tashirj]

Problem

make test-e2e fails immediately with:
Syntax Error Parsing Label Filter
Platform:
Missing set operation.

The shell word-splits the unquoted $(E2E_GINKGO_LABEL_FILTER) expansion,
so Ginkgo only sees "Platform:" instead of the full expression.

Fix

Wrap $(E2E_GINKGO_LABEL_FILTER) in single quotes at the call site.

Summary by CodeRabbit

• Tests
  • Improved end-to-end test execution by making label-based test filtering more reliable.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tashirj
Once this PR has been reviewed and has the lgtm label, please assign bharath-b-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @tashirj. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f8fe5394-691f-4dc1-8209-5c24ab5e2d00

📥 Commits

Reviewing files that changed from the base of the PR and between dc5057c and 9088e8c.

📒 Files selected for processing (1)

• Makefile

---

Walkthrough

The test-e2e Makefile target now passes -ginkgo.label-filter with the label filter value wrapped in single quotes.

Changes

E2E test target

Layer / File(s)	Summary
Quote Ginkgo label filter Makefile	test-e2e now supplies -ginkgo.label-filter as a single-quoted value instead of an unquoted argument.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	⚠️ Warning	Added e2e specs use unsupported MicroShift APIs (operator.openshift.io, openshift-monitoring/prometheus-k8s) and a TechPreview requirement, with no MicroShift skip/tag guards.	Tag or guard those specs with [apigroup:...] or [Skipped:MicroShift], or remove MicroShift-incompatible monitoring/tech-preview assumptions.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the Makefile fix to shell quoting for the test-e2e label filter.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only the Makefile e2e recipe changed; no Ginkgo It/Describe/Context/When titles were added or modified.
Test Structure And Quality	✅ Passed	PASS: The PR only adjusts Makefile shell quoting for test-e2e; no Ginkgo test code or test structure changes are part of the fix.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only Makefile quoting changed; no new or modified Ginkgo e2e tests were added, so there’s nothing to flag for SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only the Makefile test-e2e invocation changed; no manifests, controllers, or topology-sensitive scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	PR only changes Makefile quoting for the test-e2e Ginkgo flag; no process-level stdout writes in main/init/TestMain/suite setup were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only the Makefile’s test-e2e command changed; no new Ginkgo e2e tests or network/IP logic were added.
No-Weak-Crypto	✅ Passed	PASS: The patch only quotes an existing Makefile arg; no weak crypto, custom crypto, or secret-comparison code was added.
Container-Privileges	✅ Passed	The PR only changes Makefile quoting; I found no privileged:true, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation:true settings in manifests.
No-Sensitive-Data-In-Logs	✅ Passed	Only a quoting change in test-e2e; the target doesn't log the label filter or any secrets, and surrounding echoes are generic status messages.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[tashirj]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.