fix: Add missing config set jira-email#962
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesJira email config support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tof1973 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/ocm-backplane/config/set.go`:
- Line 120: The setConfig flow is overwriting the saved Jira email even when
updating unrelated settings because bpConfig.JiraEmail is never hydrated from
viper before viper.Set is called. In setConfig, either load the existing Jira
email from viper alongside JiraToken before writing, or guard the
viper.Set(config.JiraEmailViperKey, ...) call so it only runs in the Jira-email
update branch; use the existing setConfig logic and JiraToken/JiraEmail handling
to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0d2a9445-2aa8-48d2-a03c-81b1244c5f4d
📒 Files selected for processing (1)
cmd/ocm-backplane/config/set.go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 53.99% 53.97% -0.02%
==========================================
Files 82 82
Lines 6323 6329 +6
==========================================
+ Hits 3414 3416 +2
- Misses 2463 2467 +4
Partials 446 446
🚀 New features to boost your workflow:
|
f18c568 to
3dfda8d
Compare
|
@Tof1973: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / Why we need it?
Add missing config set jira-email argument
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash
Summary by CodeRabbit
ocm backplane config setcommand now supports updating the Jira email setting.jira-email) is recognized as a supported setting.