[SREP-4818] docs: add intructions to install with Homebrew#939
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gvnnn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe PR updates the ChangesInstallation Documentation Improvements
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 14-22: The README currently implies Go 1.19 is a global
prerequisite; restrict the Go prerequisite to source builds by moving or
duplicating the Go 1.19 requirement into the "Build from source" section and
removing it from top-level or MacOS install instructions (specifically update
the "MacOS" section and the global prerequisites so Homebrew install example for
backplane-cli doesn't imply Go is required); ensure the "Build from source"
heading explicitly lists "Go 1.19" and any build steps that require it so users
installing via Homebrew or downloads aren't misled.
- Line 14: Update the user-facing heading text that currently reads "MacOS" to
use the official product casing "macOS" in the README (change the heading line
with "### MacOS" to "### macOS") so documentation is consistent with product
naming.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 305a46af-7974-4b42-a50e-5d0041e8d4cf
📒 Files selected for processing (1)
README.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 53.99% 53.99%
=======================================
Files 82 82
Lines 6323 6323
=======================================
Hits 3414 3414
Misses 2463 2463
Partials 446 446 🚀 New features to boost your workflow:
|
| ### MacOS | ||
|
|
||
| ```brew | ||
| brew install backplane-cli |
There was a problem hiding this comment.
You need to add some Tap first that has this in it right? Or are we publicly listing this in the upstream homebrew tap?
There was a problem hiding this comment.
It's part of homebrew-core, no need to add a tap.
|
Note for reviewer: since the tools are meant for internal use I've created a dedicated tap and will submit a removal request to homebrew-core. Until then, even when the tap is "tapped", the installation command will require the full namespace to avoid collisions with homebrew-core. I will update the instructions once again once the formulae have been removed from homebrew-core. |
|
@gvnnn: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / Why we need it?
backplane-cliis now available within Homebrew, therefore instructions to install it should reflect that.Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
None.
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash
Summary by CodeRabbit