Skip to content

[ENH] V1 -> V2 Migration : Runs#1616

Open
Omswastik-11 wants to merge 307 commits intoopenml:mainfrom
Omswastik-11:runs-migration-stacked
Open

[ENH] V1 -> V2 Migration : Runs#1616
Omswastik-11 wants to merge 307 commits intoopenml:mainfrom
Omswastik-11:runs-migration-stacked

Conversation

@Omswastik-11
Copy link
Copy Markdown
Contributor

@Omswastik-11 Omswastik-11 commented Jan 15, 2026

Metadata

  • Reference Issue:
  • New Tests Added:
  • Documentation Updated:
  • Change Log Entry:

Details

fixes #1624

@geetu040 geetu040 mentioned this pull request Jan 15, 2026
18 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 56.25000% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.06%. Comparing base (e653ef6) to head (74eb7ae).

Files with missing lines Patch % Lines
openml/_api/resources/run.py 74.39% 21 Missing ⚠️
openml/_api/clients/http.py 16.66% 20 Missing ⚠️
openml/runs/run.py 31.57% 13 Missing ⚠️
openml/runs/functions.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
- Coverage   54.67%   54.06%   -0.62%     
==========================================
  Files          63       63              
  Lines        5108     5159      +51     
==========================================
- Hits         2793     2789       -4     
- Misses       2315     2370      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with base pr
sdk code look good so far, please take a look at #1575 (comment) and make changes accordingly where needed.
all tests (existing and new) should pass to make sure we are retaining the original functionality of the sdk

Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/_api/resources/runs.py Outdated
Comment thread openml/runs/functions.py Outdated
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
@Omswastik-11 Omswastik-11 requested a review from geetu040 January 30, 2026 09:50
@Omswastik-11 Omswastik-11 marked this pull request as ready for review January 30, 2026 09:50
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Comment thread openml/runs/functions.py Outdated
Comment on lines +822 to +828
use_cache = not ignore_cache
reset_cache = ignore_cache
return api_context.backend.runs.get(
run_id,
use_cache=use_cache,
reset_cache=reset_cache,
)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_cache should be true since the method always supports caching
reset_cache should rely on ignore_cache

Copilot AI review requested due to automatic review settings April 3, 2026 11:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot AI review requested due to automatic review settings April 3, 2026 11:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Comment thread openml/runs/functions.py Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this function now, since it's not used anywhere

Comment thread openml/runs/functions.py Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment thread openml/runs/run.py
@Omswastik-11 Omswastik-11 requested a review from geetu040 April 3, 2026 13:19
@Omswastik-11
Copy link
Copy Markdown
Contributor Author

Hi @geetu040 . As per discussion in final mentoring meeting isn't it ready to merge ?

Copy link
Copy Markdown
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is close to getting merged, just a few review comments

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following on the last unresolved review comment https://github.com/openml/openml-python/pull/1616/changes#r2988760874
what are these changes? is it a merge fault?

Copy link
Copy Markdown
Contributor Author

@Omswastik-11 Omswastik-11 May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was because of this https://github.com/openml/openml-python/actions/runs/25209014637/job/73915466617?pr=1616 . I had updated it . Should I look for a alternate solution ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geetu040

8da79d3

I have override the publish to pass the tests . Is it good or should I come up with better solution ?

Comment thread openml/runs/functions.py Outdated
Comment thread openml/runs/run.py
Comment thread tests/test_api/test_run.py Outdated
Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>
Copilot AI review requested due to automatic review settings May 1, 2026 08:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openml/runs/run.py
Comment thread openml/_api/clients/http.py
Comment thread openml/_api/resources/run.py
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Copilot AI review requested due to automatic review settings May 1, 2026 09:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openml/runs/run.py
Comment thread tests/test_api/test_run.py
Comment thread openml/_api/clients/http.py
Comment thread openml/_api/clients/http.py
Comment thread openml/_api/resources/base/resources.py
@Omswastik-11 Omswastik-11 requested a review from geetu040 May 1, 2026 10:17
…rver

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Copilot AI review requested due to automatic review settings May 1, 2026 11:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
@Omswastik-11
Copy link
Copy Markdown
Contributor Author

Omswastik-11 commented May 2, 2026

Hi @geetu040 !! Can you check the replies to reviews and the failing tests and let me know if any changes needed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - runs

8 participants