Skip to content

Commit 08e2ae8

Browse files
committed
implemented some sort of unit test. should be improved
1 parent e37bb93 commit 08e2ae8

1 file changed

Lines changed: 18 additions & 1 deletion

File tree

tests/test_runs/test_run_functions.py

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import openml
44
import openml.exceptions
5+
import json
6+
57
from openml.testing import TestBase
68
from openml.runs.functions import _run_task_get_arffcontent
79

@@ -39,7 +41,22 @@ def _perform_run(self, task_id, num_instances, clf, check_setup=True):
3941
run_id = run_.run_id
4042
run_prime = openml.runs.get_run(run_id)
4143
clf_prime = openml.setups.initialize_model(run_prime.setup_id)
42-
self.assertEquals(clf.get_params(), clf_prime.get_params())
44+
45+
params_orig = clf.get_params()
46+
params_serv = clf_prime.get_params()
47+
self.assertEqual(params_orig.keys(), params_serv.keys())
48+
49+
for param in params_orig:
50+
print("%s : %s" %(param, str(params_serv[param])))
51+
try:
52+
value_orig = json.dumps(params_orig[param])
53+
value_serv = json.dumps(params_serv[param])
54+
self.assertEqual(value_orig, value_serv)
55+
except TypeError:
56+
# TODO: think of a different check
57+
print('Object not json serializable')
58+
59+
#self.assertEquals(clf.get_params(), clf_prime.get_params())
4360
# self.assertEquals(clf, clf_prime)
4461

4562
return run

0 commit comments

Comments
 (0)