almost finished reinstatiating setups

Author: janvanrijn

openml/setups/functions.py

@@ -95,7 +95,7 @@ def _reconstruct_flow(_flow, _params):
         # (obtained by using the subfunction _to_dict_of_dicts)
         for _param in _flow.parameters:
             _flow.parameters[_param] = _params[_flow.flow_id][_param]
-        for _identifier in flow.components:
+        for _identifier in _flow.components:
             _flow.components[_identifier] = _reconstruct_flow(_flow.components[_identifier], _params)
         return _flow
 

openml/testing.py

@@ -17,6 +17,7 @@ class TestBase(unittest.TestCase):
     def setUp(self):
         # This cache directory is checked in to git to simulate a populated
         # cache
+        self.maxDiff = None
         self.static_cache_dir = None
         static_cache_dir = os.path.dirname(os.path.abspath(inspect.getfile(self.__class__)))
 

tests/test_runs/test_run_functions.py

@@ -25,7 +25,7 @@
 
 class TestRun(TestBase):
 
-    def _perform_run(self, task_id, num_instances, clf):
+    def _perform_run(self, task_id, num_instances, clf, check_setup=True):
         task = openml.tasks.get_task(task_id)
         run = openml.runs.run_task(task, clf, openml.config.avoid_duplicate_runs)
         run_ = run.publish()
@@ -34,6 +34,14 @@ def _perform_run(self, task_id, num_instances, clf):
 
         # check arff output
         self.assertEqual(len(run.data_content), num_instances)
+
+        if check_setup:
+            run_id = run_.run_id
+            run_prime = openml.runs.get_run(run_id)
+            clf_prime = openml.setups.initialize_model(run_prime.setup_id)
+            self.assertEquals(clf.get_params(), clf_prime.get_params())
+            # self.assertEquals(clf, clf_prime)
+
         return run
 
     def test_run_regression_on_classif_task(self):