deps: expose reqwest TLS backend features#145
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfbadbc66f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| default = [] | ||
| # Use the pure-Rust `rustls` TLS backend by default so we don't depend on an | ||
| # OpenSSL installation on the CI runners. | ||
| default = ["rustls-tls"] |
There was a problem hiding this comment.
If a downstream crate already depends on openai-harmony with default-features = false, this change turns what used to be a no-op into a build of reqwest with neither TLS backend enabled unless the downstream also adds rustls-tls or native-tls. In that configuration Encoding::load still downloads the default https://openaipublic.blob.core.windows.net/... vocab through reqwest::blocking::Client, so uncached loads fail for HTTPS even though the same no-default build worked before when reqwest/rustls-tls was unconditional.
Useful? React with 👍 / 👎.
1 participant
Expose features including
native-tlsandrustls-tlsso that users can choose between different TLS backends based on their need.rustls-tlsis still used by default, so there's no user-facing breaking change.