feat: add two-step Ownable mixin with tests#6
Merged
Conversation
Pending-owner must accept before ownership transfers - avoids the classic foot-gun where a typo'd address ends up as owner. Renounce stays single-step but zeroes pendingOwner too. Custom errors throughout. Concrete OwnableHarness in the test file lets the abstract base be deployed for unit tests.
Owner
Author
|
Reviewed - two-step is the right default. The 'transfer overwrites pending' test catches the subtle case where a stale pending owner could otherwise still accept after a second transfer. Merging. |
oliv3rdrt
added a commit
that referenced
this pull request
Jun 27, 2026
Pending-owner must accept before ownership transfers - avoids the classic foot-gun where a typo'd address ends up as owner. Renounce stays single-step but zeroes pendingOwner too. Custom errors throughout. Concrete OwnableHarness in the test file lets the abstract base be deployed for unit tests. Co-authored-by: Oliver Anyanwu <oliver.anyanwu@aol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/Ownable.sol: abstract base.transferOwnershipsetspendingOwner; the new owner must callacceptOwnershipfor the change to take effect.renounceOwnershipis intentionally single-step.NotOwner,NotPendingOwner) save deploy bytes vs. require strings.test/Ownable.t.sol: 7 tests using anOwnableHarnessconcrete impl. Covers happy path, mid-flight overwrite of pending owner, accept-while-not-pending, renounce, and the access-control guard.Test plan
forge test --match-contract OwnableTest- 7/7forge test- 48/48, no regressions