polishing NF wallet#6900
Open
benedettadavico wants to merge 18 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ts bucket Replace the easingthemes/ssh-deploy (SSH/rsync to *.ci.nymte.ch) upload with a reusable ./.github/actions/push-to-s3 composite action that `aws s3 sync`s the CI artifacts to the new `assets` bucket (API endpoint https://s3.nymte.ch).
Introduces the formal specification documents outlining UI/UX improvements and bug fixes for the Node Families feature. This openspec details the context, design decisions, and requirements for issues identified during QA (e.g., frozen timers, loading state bleed, misplaced sections, padding, and specific Jira tickets NYM-1558/1559/1560). It serves as the blueprint for subsequent code changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
Important Review skippedToo many files! This PR contains 276 files, which is 126 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (24)
📒 Files selected for processing (276)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Extends the `node-families-ui-polish` openspec by introducing the `family-nav-invite-badge` capability. This includes detailed requirements (R1-R6), design decisions (D10), and implementation tasks. It defines how a visual indicator will be displayed on the 'Family' nav item when the user's controlled node has pending family invitations, ensuring app-wide availability without coupling to the `FamiliesContext`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.