NTM: add 9000#6855
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughOne line added to the WireGuard exit policy port allowlist in the network tunnel manager script, configuring the "WebSocket" service to use TCP/UDP port 9000. ChangesWebSocket Service Port Mapping
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/nym-node-setup/network-tunnel-manager.sh`:
- Line 944: The associative array contains a duplicate key "WebSocket" (earlier
set to "6300") which is overwritten by the later ["WebSocket"]="9000"; update
the entry so both ports are preserved—either merge the values into one entry
(e.g., set "WebSocket" to "6300,9000" and update any parsing logic that reads
it) or use unique keys per port (e.g., "WebSocket_6300" and "WebSocket_9000") or
convert the structure to an array-of-ports; locate the duplicate "WebSocket"
entries in network-tunnel-manager.sh and apply one of these fixes and adjust any
consumer code that expects a single port value (functions/variables that read
the associative array) accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b2dc7d11-d485-49a6-82a1-a9d72f781c3f
📒 Files selected for processing (1)
scripts/nym-node-setup/network-tunnel-manager.sh
| ["TeamSpeak"]="8767" | ||
| ["MQTTS"]="8883" | ||
| ["HTTPProxy"]="8888" | ||
| ["WebSocket"]="9000" |
There was a problem hiding this comment.
Duplicate associative-array key overwrites the earlier WebSocket port
Line 944 reuses the WebSocket key, so in Bash the earlier ["WebSocket"]="6300" entry is overwritten and only port 9000 remains. If the intent is to add 9000, this currently removes 6300 from the effective allowlist.
Suggested fix
- ["WebSocket"]="6300"
+ ["WebSocketLegacy"]="6300"
@@
- ["WebSocket"]="9000"
+ ["WebSocket"]="9000"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/nym-node-setup/network-tunnel-manager.sh` at line 944, The
associative array contains a duplicate key "WebSocket" (earlier set to "6300")
which is overwritten by the later ["WebSocket"]="9000"; update the entry so both
ports are preserved—either merge the values into one entry (e.g., set
"WebSocket" to "6300,9000" and update any parsing logic that reads it) or use
unique keys per port (e.g., "WebSocket_6300" and "WebSocket_9000") or convert
the structure to an array-of-ports; locate the duplicate "WebSocket" entries in
network-tunnel-manager.sh and apply one of these fixes and adjust any consumer
code that expects a single port value (functions/variables that read the
associative array) accordingly.
trying to make socks5 behind nymvpn by adding 9000 to exit policy rules
This change is
Summary by CodeRabbit