Execute SET_FUNCTION_ATTRIBUTE before wrapping for #617#620
Merged
MatthieuDartiailh merged 1 commit intonucleic:mainfrom Apr 22, 2026
Merged
Execute SET_FUNCTION_ATTRIBUTE before wrapping for #617#620MatthieuDartiailh merged 1 commit intonucleic:mainfrom
MatthieuDartiailh merged 1 commit intonucleic:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 65.99% 66.06% +0.07%
==========================================
Files 270 270
Lines 26576 26584 +8
Branches 3899 3901 +2
==========================================
+ Hits 17538 17564 +26
+ Misses 7990 7975 -15
+ Partials 1048 1045 -3 🚀 New features to boost your workflow:
|
Member
|
I will try to think of something but I wonder what is your use case. |
frmdstryr
force-pushed
the
update-defaults
branch
from
52b0345 to
7f38fd6
Compare
frmdstryr
changed the title
Contributor
Author
|
It appears the defaults can already access the dynamicscope so it's not a problem. |
frmdstryr
force-pushed
the
update-defaults
branch
from
7f38fd6 to
f42b078
Compare
MatthieuDartiailh
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 3.13+, when a function has defaults it uses the new SET_FUNCTION_ATTRIBUTE instruction. This updates the run_in_dynamicscope to take account for it.