Fix annotation fn's not runing in dynamicscope for #616#619
Merged
MatthieuDartiailh merged 2 commits intonucleic:mainfrom Apr 21, 2026
Merged
Fix annotation fn's not runing in dynamicscope for #616#619MatthieuDartiailh merged 2 commits intonucleic:mainfrom
MatthieuDartiailh merged 2 commits intonucleic:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 65.99% 65.99% -0.01%
==========================================
Files 270 270
Lines 26590 26576 -14
Branches 3908 3899 -9
==========================================
- Hits 17549 17538 -11
+ Misses 7992 7990 -2
+ Partials 1049 1048 -1 🚀 New features to boost your workflow:
|
70925e7 to
f047500
Compare
Member
|
Can you rebate? |
f047500 to
6daebdd
Compare
Contributor
Author
|
Rebased |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #618.
The commit 7478234 is not necessary but cleans up the code slightly (I can move it to a separate PR).
For context, I added a few statements to print the function and outer_ops in insert_decl_function and ran the code in #616 on 3.14.The output was:
So it looks like python adds a separate function for annotations and it was selecting the code from the first function.