deps: fix ast-value-factory build without shared RO heap#62664
Open
DaveT1991 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Open
deps: fix ast-value-factory build without shared RO heap#62664DaveT1991 wants to merge 1 commit intonodejs:v22.x-stagingfrom
DaveT1991 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
Signed-off-by: DaveT1991 <dawoodaljanaby@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a V8 build regression on the
v22.xline when Node is configured with--disable-shared-readonly-heap.Problem
Building Node 22.22.2 without
V8_SHARED_RO_HEAPfails indeps/v8/src/ast/ast-value-factory.ccbecause the code tries to retrieve read-only roots with a shared-RO-heap accessor that is not available in that configuration.Root cause
The backported V8 change switched
AstRawString::AsArrayIndex()to decode cached array indexes using a hash seed from read-only roots, but this call site used the wrong accessor for non-shared-readonly-heap builds.Fix
deps/v8/src/ast/ast-value-factory.ccwith the currentmainbranch implementationHashSeed(GetReadOnlyRoots())at the call siteTesting
git diff --checkmainbranch implementationFixes: #62631