test: log MSBuild output on Windows build failures#3328
Open
legendecas wants to merge 1 commit into
Open
Conversation
Member
Author
|
The error seems to be: |
Contributor
|
From what I understand, the idea behind this draft PR is that you wanted to see what the problem was with Node.js v26 tests on Windows. The question I have is, do we want to keep this change to be able to get more information in the future or would that not be useful to have? |
Member
Author
Yes, I think this is generally helpful and worth to keep. |
legendecas
force-pushed
the
debug/win-node26-ci-logging
branch
from
ff52fd5 to
b9e5386
Compare
legendecas
force-pushed
the
debug/win-node26-ci-logging
branch
from
b9e5386 to
f50be52
Compare
legendecas
changed the title
cclauss
requested changes
Jun 11, 2026
cclauss
left a comment
cclauss
left a comment
Contributor
There was a problem hiding this comment.
Please fix order of return values.
|
|
||
| const execFile = async (cmd) => { | ||
| const [err,, stderr] = await util.execFile(process.execPath, cmd, { | ||
| const [err, stdout, stderr] = await util.execFile(process.execPath, cmd, { |
| encoding: 'utf-8' | ||
| }) | ||
| return [err, stderr.toString().trim().split(/\r?\n/)] | ||
| return [err, stderr.toString().trim().split(/\r?\n/), stdout.toString().trim()] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
Refs: #3327