Skip to content

Fix build bug in target arch config#2941

Open
lukekarrys wants to merge 1 commit into
mainfrom
lk/configure-char
Open

Fix build bug in target arch config#2941
lukekarrys wants to merge 1 commit into
mainfrom
lk/configure-char

Conversation

@lukekarrys

@lukekarrys lukekarrys commented Nov 3, 2023

Copy link
Copy Markdown
Member

Note: This is place of #2866 since I was not able to finish pushing to the original fork.

Fixes #2865


TODO:

  • add test for this scenario

@lukekarrys lukekarrys changed the title Update configure.js Fix build bug in target arch config Nov 6, 2023
@cclauss

cclauss commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

@imatlopez suggestion at #2866 (review)

@tmm1

tmm1 commented Jan 5, 2025

Copy link
Copy Markdown
Contributor

Can this be merged? Pretty obvious typo..

@cclauss

cclauss commented Jan 5, 2025

Copy link
Copy Markdown
Contributor

It needs a test added #2866 (review) and needs the tests to pass.

@cclauss

cclauss commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Please rebase because this line has moved from 220 to 266.

!gyp.opts.nodedir ? '<(target_arch)' : '$(Configuration)',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build bug in target arch config

4 participants