feat: add confirmation steps to any write operation#1092
Open
RafaelGSS wants to merge 1 commit into
Open
Conversation
aduh95
reviewed
Jun 10, 2026
| const allowed = await cli.prompt(message, { defaultAnswer: false }); | ||
| if (!allowed) { | ||
| cli.info(`Aborted: ${action}.`); | ||
| process.exit(0); |
Contributor
There was a problem hiding this comment.
Let's not call process.exit, that's an anti-pattern (refs #1089)
aduh95
reviewed
Jun 10, 2026
Comment on lines
+38
to
+42
| const lines = [`Allow action: ${action}?`]; | ||
| if (detail) { | ||
| lines.push('', detail); | ||
| } | ||
| const message = lines.join('\n'); |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| const lines = [`Allow action: ${action}?`]; | |
| if (detail) { | |
| lines.push('', detail); | |
| } | |
| const message = lines.join('\n'); | |
| let message = `Allow action: ${action}?`; | |
| if (detail) { | |
| message += `\n\n${detail}`; | |
| } |
aduh95
reviewed
Jun 10, 2026
Comment on lines
+107
to
+111
| await runSecurityGitCommand( | ||
| cli, | ||
| ['add', filePath], | ||
| `This stages ${filePath} for the security release commit.` | ||
| ); |
Contributor
There was a problem hiding this comment.
I don't think it makes sense to prompt for this, as this is a local-only operation, and non destructive.
aduh95
reviewed
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One concern that @aduh95 shared with me is that
git node security *performs a lot of things in the background without asking for permissions. This PR aims to add a security confirmation before any write operation.