Open
Conversation
Contributor
Author
|
Most of the files are identical to the original source. |
kraenhansen
approved these changes
Mar 30, 2026
Contributor
|
Reviewed: C files are verbatim copies of upstream, CMakeLists.txt correctly lists both sources, all upstream test cases preserved, all |
Contributor
Author
|
@kraenhansen Do you have any opinion on "use strict"? |
Contributor
|
@bavulapati I think it's redundant but also in alignment with what I've already merged. Let's keep it as-is and then update in bulk later 👍 |
bavulapati
commented
Apr 7, 2026
legendecas
reviewed
Apr 9, 2026
| | `test_array` | Ported ✅ | Easy | | ||
| | `test_bigint` | Ported ✅ | Easy | | ||
| | `test_cannot_run_js` | Not ported | Medium | | ||
| | `test_conversions` | Ported ✅ | Medium | |
Member
There was a problem hiding this comment.
Line 54 should be updated instead.
bavulapati
force-pushed
the
feat/port-test-conversions
branch
from
a510746 to
2da801e
Compare
Ports [test_conversions](https://github.com/nodejs/node/tree/main/test/js-native-api/test_conversions) from the Node.js test suite to the CTS. Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Exercises napi_define_class with method, data value, accessor, and static property descriptors. Includes null-argument tests for napi_define_class via test_null.c/test_null.js. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
force-pushed
the
feat/port-test-conversions
branch
from
c3ece25 to
9ef3fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports test_conversions from the Node.js test suite to the CTS.