Replace eslint with biome#439
Open
jankapunkt wants to merge 5 commits into
Open
Conversation
dhensby
reviewed
Jun 15, 2026
Contributor
There was a problem hiding this comment.
I don't feel too strongly one way or the other for biome vs eslint; I'd slightly lean towards eslint due to familiarity, native JS and maturity, but it's not a show stopper.
Feedback:
- I ran biome locally and got some changes, which I'm not sure if we want or not given that it means if some other contributor runs
biome lint --writethen they will get quite a big diff which isn't committed and could cause noise in other PRs. - You've moved from spaces -> tabs, and single to double quotes. Both changes create significant diff noise, personally I'd keep the current formatting conventions where possible to reduce this noise - but not a deal breaker; we could also add a
.git-blame-ignore-revsfile that can hide these reformat changes from blames to keep disruption down due to formatting changes. - I'd reword some of the commits (a bit pedantic, sorry):
a)feature(dev): replace eslint with biome toolchain:chore(deps-dev): ...is typical for this kind of change
b)fix(core): biome format fix:stype: ..."fix" commits tend to be for fixing bugs, this is just internal code reorganisation so not worthy offixcommit IMO
c)fix: run biome formatterisdocs: add biome badge
d)fix run biome formatter fix:style:again, I'd probably fixup into the previous refactor commit
e)fix(tests): detect different line in emitted error after biome formatter fixes:test: ...
dhensby
requested changes
Jun 15, 2026
dhensby
left a comment
Contributor
There was a problem hiding this comment.
- Should we split out the other dep bumps (type-is, mocha, sinon, vitepress) to their own commits or PR?
- Runnint
npm run lint:fixcreates a lot of changes (when I ran it locally anyway), which I don't think it should otherwise (as I said previously) other contributors will find themselves with a lot of noise when running this command.
Comment on lines
+8
to
+11
| "files": { | ||
| "ignoreUnknown": true, | ||
| "includes": ["lib/**/*.js", "test/**/*.js"] | ||
| }, |
dhensby
requested changes
Jun 15, 2026
Comment on lines
+18
to
+20
| "rules": { | ||
| "preset": "recommended" | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| "rules": { | |
| "preset": "recommended" | |
| } | |
| "rules": { | |
| "preset": "recommended", | |
| "suspicious": { | |
| "noRedundantUseStrict": "off" | |
| } | |
| } |
This will stop npm run lint:fix from stripping "use strict" (which I assume we want to keep)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces eslint with biome with remains compatible with commonjs and is also able to handle (future) esm (see #279)
Please do not get scared of the change files. While the linter only produced warnings, the formatter produced lots of errors, which were automatically fixable (similar to how prettier works)
Linked issue(s)
#403 #279
Involved parts of the project
Added tests?
OAuth2 standard
Reproduction
clone and run one of the following: