Request for Comments: Backwards compatible yaml-options rename#1096
Open
visrosa wants to merge 1 commit into
Open
Request for Comments: Backwards compatible yaml-options rename#1096visrosa wants to merge 1 commit into
visrosa wants to merge 1 commit into
Conversation
… aliases Add oviewer/compat.go, which registers new canonical names as forward aliases for existing internal names across two config surfaces: - viper aliases map new YAML/env-var key names to existing internal keys, so configs written with new names load correctly without any internal rename. - Action dispatch aliases add new action string names alongside the existing ones: alternate_rows_mode, column_rainbow_mode, write_on_exit, hide_other_section, row_header, row_header_column, write_exit_range, debug_log. A deprecation warning is emitted to stderr for each old-name key detected in the loaded configuration (file, env var, or CLI flag). The check runs before alias registration so viper.IsSet reflects direct usage only. No internal names change; all existing config files, env vars, and custom keybind configs continue to work unchanged. Reference configs (ov.yaml, ov-less.yaml, ov.yaml.template) updated to use the new canonical names throughout.
visrosa
force-pushed
the
ux/yaml-backwards-compatible-rename
branch
from
ef08a3f to
ae92157
Compare
visrosa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in my first PR, I have some user interface suggestions involving renaming some YAML options and CLI flags.
This is a showcase of the changes I would propose, without breaking backward compatibility.
Disclaimer: this PR is AI-assisted. This PR is presented exclusively for review and comment, not for merging as-is.