Skip to content

fix: Fix dialog button wording to be more understandable#1093

Merged
CarlSchwan merged 1 commit intomasterfrom
fix/buttons-wording
Apr 30, 2026
Merged

fix: Fix dialog button wording to be more understandable#1093
CarlSchwan merged 1 commit intomasterfrom
fix/buttons-wording

Conversation

@jancborchardt
Copy link
Copy Markdown
Member

Reported by @Cloudboom in design feedback Talk conversation. :)

  • Changed wording of main button from "Edit" to "Save changes". Also makes it more understandable why it is greyed out / disabled by default
  • Changed wording of "Cancel" to "Cancel changes" and moved it leftmost, so there is less likelihood of accidentally clicking
Before After
Screenshot From 2026-04-30 12-36-55 Screenshot From 2026-04-30 12-36-28
Screenshot From 2026-04-30 12-37-00 Screenshot From 2026-04-30 12-36-36

Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@CarlSchwan CarlSchwan merged commit e17f41b into master Apr 30, 2026
49 checks passed
@CarlSchwan CarlSchwan deleted the fix/buttons-wording branch April 30, 2026 11:03
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Apr 30, 2026
@CarlSchwan CarlSchwan added this to the 8.0.1 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants