Skip to content

fix: don't fail sphinxbuild.yml if netlify deploy fails#14777

Merged
skjnldsv merged 1 commit intomasterfrom
copilot/fix-sphinxbuild-on-netlify-fail
May 6, 2026
Merged

fix: don't fail sphinxbuild.yml if netlify deploy fails#14777
skjnldsv merged 1 commit intomasterfrom
copilot/fix-sphinxbuild-on-netlify-fail

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

On forks, NETLIFY_AUTH_TOKEN and NETLIFY_SITE_ID secrets are unavailable, causing the netlify-preview job to fail and blocking the entire workflow via the summary job's result check.

The summary job's PR-branch condition now accepts failure in addition to success for netlify-preview, matching the already-present continue-on-error: true intent on the deploy step:

# Before
|| needs.netlify-preview.result != 'success'

# After
|| (needs.netlify-preview.result != 'success' && needs.netlify-preview.result != 'failure')

☑️ Resolves

🖼️ Screenshots

N/A — CI workflow change only.

✅ Checklist

  • I have built the documentation locally and reviewed the output
  • Screenshots are included for visual changes
  • I have not moved or renamed pages (or added a redirect if I did)
  • I have run codespell or similar and addressed any spelling issues

@skjnldsv skjnldsv requested a review from miaulalala May 6, 2026 09:16
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 6, 2026
@skjnldsv skjnldsv marked this pull request as ready for review May 6, 2026 09:21
@skjnldsv skjnldsv enabled auto-merge May 6, 2026 09:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

📖 Documentation Preview

🔍 Open preview →

No RST documentation pages changed in this PR.

Last updated: Wed, 06 May 2026 09:24:09 GMT

@skjnldsv skjnldsv merged commit f4a9700 into master May 6, 2026
26 checks passed
@skjnldsv skjnldsv deleted the copilot/fix-sphinxbuild-on-netlify-fail branch May 6, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants