Merged
Conversation
- Add sphinx-lint==1.0.2 to requirements.txt - Create .github/workflows/sphinx-lint.yml (disabling trailing-whitespace and horizontal-tab which have thousands of pre-existing violations) - Fix 38 pre-existing RST violations across all three manuals: - 27 files missing final newline - Malformed hyperlinks (missing space, missing underscore) - Unbalanced inline literal delimiters - Role markup errors (missing backticks, missing colons) - Dangling hyphen in URL (converted to inline hyperlink) Agent-Logs-Url: https://github.com/nextcloud/documentation/sessions/13a4f646-2926-4695-8df9-87521fbb2383 Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nextcloud/documentation/sessions/13a4f646-2926-4695-8df9-87521fbb2383 Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add sphinx-lint as a CI step for RST files
Add sphinx-lint CI for RST files
May 6, 2026
Member
We'll fix them later |
…t dual-install intent Agent-Logs-Url: https://github.com/nextcloud/documentation/sessions/c8666b05-c4aa-478f-a667-a8619d24faae Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
Contributor
skjnldsv
approved these changes
May 6, 2026
miaulalala
approved these changes
May 6, 2026
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/14769/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ae8a2ddf da96ed6a 2fdbc702 afaf0ec8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14769/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/14769/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ae8a2ddf da96ed6a 2fdbc702 afaf0ec8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14769/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Copilot AI
added a commit
that referenced
this pull request
May 6, 2026
Cherry-pick of PR #14769 onto stable32: - Add sphinx-lint==1.0.2 to requirements.txt - Create .github/workflows/sphinx-lint.yml - Add sphinx-lint problem matcher - Fix pre-existing RST violations (missing final newlines, malformed hyperlinks, role markup errors)
Copilot AI
added a commit
that referenced
this pull request
May 6, 2026
Agent-Logs-Url: https://github.com/nextcloud/documentation/sessions/6b11b4b0-a802-44c0-a74c-c00f012eac7c Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sphinx-lintas a dedicated CI linting step for the three manuals, and fixes all pre-existing violations so the check passes cleanly from day one.CI workflow (
.github/workflows/sphinx-lint.yml)ubuntu-latest, separate from the heavysphinxbuild.yml(no PDF/Docker)pull_request+pushtomaster/stable*sphinx-lint --disable trailing-whitespace --disable horizontal-tab— those two checks have thousands of pre-existing violations that need incremental cleanup; all other checks are enforcedrequirements.txtsphinx-lint==1.0.2(pinned, consistent with rest of file)Pre-existing violations fixed (38 total)
app_summary_bot.rst,upgrade_to_20.rst,sync_windows10.rstocs-openapi.rst,upgrade_to_33.rstserver_tuning.rst,filesystem.rst,commandline.rst,ocs-openapi.rstsync_windows10.rst— URL ending in-in a link definition; converted to inline hyperlink☑️ Resolves
🖼️ Screenshots
✅ Checklist
codespellor similar and addressed any spelling issuesOriginal prompt
This pull request was created from Copilot chat.