Skip to content

FileDetailSharingFragment Kotlin#17084

Open
alperozturk96 wants to merge 11 commits into
masterfrom
file-detail-sharing-fragment-kt
Open

FileDetailSharingFragment Kotlin#17084
alperozturk96 wants to merge 11 commits into
masterfrom
file-detail-sharing-fragment-kt

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • Simplifies and organize logic
  • Increases performance
  • Better thread management

@alperozturk96 alperozturk96 marked this pull request as draft May 22, 2026 13:29
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26290662502/artifacts/7161822597
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented May 23, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26324906540/artifacts/7174679305
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from ffb4382 to 34f7855 Compare June 3, 2026 08:58
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26875361461/artifacts/7381099060
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from 39216bb to 726a7b9 Compare June 3, 2026 10:02
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26878329563/artifacts/7381956473
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from 8200369 to 6a5f493 Compare June 5, 2026 13:49
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27018757572/artifacts/7438350802
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27019785275/artifacts/7438735878
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27022113982/artifacts/7439940274
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from eddb0db to 5819505 Compare June 5, 2026 15:27
@alperozturk96 alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Jun 5, 2026
@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jun 5, 2026
@alperozturk96 alperozturk96 marked this pull request as ready for review June 5, 2026 15:36
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27024434283/artifacts/7440898221
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from 9eeec97 to 0da5df5 Compare June 10, 2026 09:56
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27268346643/artifacts/7533228201
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96

alperozturk96 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

@tobiasKaminsky how can we fix this?

Screenshot 2026-06-11 at 09 41 16

@alperozturk96
Rename .java to .kt
b9ca11b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
file-detail-sharing-fragment kotlin
1922303 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
cd0ed5b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
d5e3b8f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
7d48bc7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
8db3358 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
b330cbf 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
082d03e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
3fee99a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
2d9f7ef 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the file-detail-sharing-fragment-kt branch from 0da5df5 to 2d9f7ef Compare June 11, 2026 07:55
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27332403085/artifacts/7558581315
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
wip
8783003 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6766
Dodgy code215210
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total413407

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27335647993/artifacts/7563187711
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Milestone

Nextcloud App 34.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96