Skip to content

Improve download file remote operation#2040

Merged
alperozturk96 merged 6 commits into
masterfrom
remove-file-size-check-during-download
Jun 10, 2026
Merged

Improve download file remote operation#2040
alperozturk96 merged 6 commits into
masterfrom
remove-file-size-check-during-download

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Removes file size checks ( as we discussed @tobiasKaminsky )
  • Uses NIO instead of Java IO
  • min SDK level 26 before was 23
  • Converts Java to Kotlin
  • Auto closes the streams

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

SpotBugs

CategoryBaseNew
Bad practice3432
Correctness2929
Dodgy code1515
Internationalization66
Malicious code vulnerability2626
Multithreaded correctness99
Performance98
Total128125

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 changed the title remove file size check while downloading Improve download file remote operation Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

SpotBugs

CategoryBaseNew
Bad practice3431
Correctness2929
Dodgy code1514
Internationalization66
Malicious code vulnerability2626
Multithreaded correctness97
Performance97
Total128120

@alperozturk96

Copy link
Copy Markdown
Contributor Author

/backport to stable-2.24.0

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

SpotBugs

CategoryBaseNew
Bad practice3431
Correctness2929
Dodgy code1514
Internationalization66
Malicious code vulnerability2626
Multithreaded correctness97
Performance97
Total128120

@alperozturk96 alperozturk96 merged commit 1f476c0 into master Jun 10, 2026
18 of 19 checks passed
@alperozturk96 alperozturk96 deleted the remove-file-size-check-during-download branch June 10, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants