Skip to content

fix: Clamp battery capacity threshold to valid range #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryanvrgsc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Clamp battery capacity threshold to valid range #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Packages/KYAApplicationSupport/Sources/KYAApplicationSupport/NSUserDefaults+KYAKeys.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ - (CGFloat)kya_batteryCapacityThreshold

- (void)setKya_batteryCapacityThreshold:(CGFloat)batteryCapacityThreshold
{
[self setFloat:(float)batteryCapacityThreshold forKey:KYAUserDefaultsKeyBatteryCapacityThreshold];
// Clamp value between 10% and 100%
CGFloat clampedThreshold = MIN(100.0f, MAX(10.0f, batteryCapacityThreshold));
[self setFloat:(float)clampedThreshold forKey:KYAUserDefaultsKeyBatteryCapacityThreshold];
}

@end
12 changes: 6 additions & 6 deletions Packages/KYAApplicationSupport/Tests/KYAApplicationSupportTests/KYAUserDefaultsKeysTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,18 @@ - (void)testBatteryCapacityThreshold
[defaults setFloat:50.0f forKey:key];
XCTAssertEqual([defaults kya_batteryCapacityThreshold], 50.0f);

// Below 10%
// Below 10% - should clamp to 10%
defaults.kya_batteryCapacityThreshold = 0.1f;
XCTAssertEqual([defaults kya_batteryCapacityThreshold], 10.0f);
XCTAssertEqual([defaults floatForKey:key], 0.1f); // TODO: Maybe the setter should catch this?
XCTAssertEqual([defaults floatForKey:key], 10.0f); // Setter now clamps the value

[defaults setFloat:0.2f forKey:key];
XCTAssertEqual([defaults kya_batteryCapacityThreshold], 10.0f);

// Over 100%
defaults.kya_batteryCapacityThreshold = 512.0f; // TODO: Maybe this should be invalid?
XCTAssertEqual([defaults kya_batteryCapacityThreshold], 512.0f);
XCTAssertEqual([defaults floatForKey:key], 512.0f);
// Over 100% - should clamp to 100%
defaults.kya_batteryCapacityThreshold = 512.0f;
XCTAssertEqual([defaults kya_batteryCapacityThreshold], 100.0f); // Clamped to 100%
XCTAssertEqual([defaults floatForKey:key], 100.0f); // Setter now clamps the value
}

@end