Fix(network): bound hole punching forward limiter keys#5221
Open
chenyukang wants to merge 1 commit into
Open
Conversation
Keep the existing per-(from, to, message type) forwarding rate-limit semantics, but replace the unbounded governor keyed store with a bounded TTL-backed limiter. This prevents peers from growing limiter state indefinitely by sending messages with fresh message-controlled peer ids.
eval-exec
approved these changes
Jun 3, 2026
Officeyutong
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
The previous limiter used
(from, to, message type)as the key, wherefromandtocome from forwarded messages. A peer could keep sending messages with fresh peer IDs and grow the keyed rate limiter state indefinitely.What is changed and how it works?
Keep the existing per-(from, to, message type) forwarding rate-limit semantics, but replace the unbounded governor keyed store with a bounded TTL-backed limiter. This prevents peers from growing limiter state indefinitely by sending messages with fresh message-controlled peer ids.
What's Changed:
Related changes
owner/repo:Check List
Tests
Side effects