Fix typo in conf for snapshot cache capacity in pageserver#12872
Open
dotdister wants to merge 1 commit intoneondatabase:mainfrom
Open
Fix typo in conf for snapshot cache capacity in pageserver#12872dotdister wants to merge 1 commit intoneondatabase:mainfrom
dotdister wants to merge 1 commit intoneondatabase:mainfrom
Conversation
…er (neondatabase#12855) Updated the configuration key from 'relsize snapshot cache capacity' to 'relsize_snapshot_cache_capacity' to ensure consistency and correct parsing in the settings. This change addresses potential issues with configuration loading.
dotdister
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When tenant settings included relsize_snapshot_cache_capacity, control_plane::pageserver::parse_config called settings.remove() with a mistyped key ("relsize snapshot cache capacity" with spaces).
The real key was never removed from the map, so parsing either failed with “unrecognized tenant settings” or the intended capacity was not applied.
This key must match the underscore form used everywhere else (relsize_snapshot_cache_capacity).
Summary of changes
Updated the configuration key from 'relsize snapshot cache capacity' to 'relsize_snapshot_cache_capacity' to ensure consistency and correct parsing in the settings.
This change addresses potential issues with configuration loading.