chore: clean up compiler warnings#12848
Open
EdanStasiuk wants to merge 5 commits intoneondatabase:mainfrom
Open
chore: clean up compiler warnings#12848EdanStasiuk wants to merge 5 commits intoneondatabase:mainfrom
EdanStasiuk wants to merge 5 commits intoneondatabase:mainfrom
Conversation
- Removed unused private `max_keys_per_delete` in `impl GCSBucket` - Kept trait declaration in `lib.rs` and its implementation in `impl RemoteStorage`
EdanStasiuk
force-pushed
the
clean-up-compiler-warnings
branch
2 times, most recently
from
ed2d0c8 to
71ed827
Compare
Author
|
@erikgrinaker this PR is ready for review when you have a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ref: #12847 - Compiler warnings being generated in remote_storage
Summary of changes
Within
libs/remote_storage/src/gcs_bucket.rs:_max_keys_per_deletefunction fromimpl GCSBucket(keep only trait implementation in RemoteStorage)