Add unit tests for cart services and update CI configuration#1503
Open
akus176 wants to merge 2 commits intonashtech-garage:mainfrom
Open
Add unit tests for cart services and update CI configuration#1503akus176 wants to merge 2 commits intonashtech-garage:mainfrom
akus176 wants to merge 2 commits intonashtech-garage:mainfrom
Conversation
…nd ProductService, and create ConstantsTest for error codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the cart service's CI pipeline and enhances test coverage for the cart service. The CI workflow is refactored for better structure and maintainability, and new unit tests are added for improved code reliability. Additionally, some configuration values are updated.
CI/CD Pipeline Improvements:
.github/workflows/cart-ci.yamlworkflow is refactored to split the build process into separateTestandBuildjobs, improve job naming, and use consistent YAML formatting. Unused or redundant steps (like Docker image build/push and OWASP Dependency Check) are removed, and coverage thresholds are updated to 70%.Test Coverage Enhancements:
AbstractCircuitBreakFallbackHandlerTestto verify fallback handler behavior.ProductServiceTestwith additional test cases for product retrieval, existence checks, and fallback handling.ConstantsTestto validate the instantiability of theConstantsclass and the correctness of error code values.Configuration Changes:
cart/pom.xmlto reflect the new organization and project.