Skip to content

fix(editor): HTTP request node showing warning about credentials not set when they are set#28270

Merged
RomanDavydchuk merged 4 commits intomasterfrom
node-4714-community-issue-http-request-node-shows-false-credentials
Apr 21, 2026
Merged

fix(editor): HTTP request node showing warning about credentials not set when they are set#28270
RomanDavydchuk merged 4 commits intomasterfrom
node-4714-community-issue-http-request-node-shows-false-credentials

Conversation

@RomanDavydchuk
Copy link
Copy Markdown
Contributor

@RomanDavydchuk RomanDavydchuk commented Apr 9, 2026

Summary

If you have a workflow with a HTTP request node that has Authentication set to Predefined Credential Type and a valid credential selected, and then go look at the one of the workflow's execution, you'll see a warning about the credentials not being set in that node:

image

but it actually has credentials. The issue is that once you open the execution, the FE does not fetch all of the credentials for the current workflow. This PR fixes that by adding a call to load credentials for the opened workflow

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4714/community-issue-http-request-node-shows-false-credentials-not-set
Closes #27521

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)
  • I have seen this code, I have run this code, and I take responsibility for this code.

@n8n-assistant n8n-assistant Bot added the n8n team Authored by the n8n team label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review April 9, 2026 17:20
@Joffcom Joffcom requested a review from michael-radency April 9, 2026 17:24
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Architecture diagram
sequenceDiagram
    participant Window as External Window/UI
    participant Handler as usePostMessageHandler
    participant ExecStore as Executions Store
    participant CredStore as Credentials Store
    participant API as Backend API

    Note over Window,API: Execution Data Loading Flow

    Window->>Handler: postMessage({ command: "openExecution", executionId })
    Handler->>ExecStore: openExecution(executionId)
    ExecStore->>API: GET /executions/{id}
    API-->>ExecStore: execution data (inc. workflowId)
    ExecStore-->>Handler: execution details

    alt Execution data found
        Handler->>CredStore: NEW: fetchAllCredentialsForWorkflow({ workflowId })
        CredStore->>API: NEW: GET /workflows/{id}/credentials
        API-->>CredStore: credential metadata list
        
        Handler->>Handler: initialize workflow document store
        Note over Handler,CredStore: Node UI resolves credentials from store, clearing warnings
    else Execution data null
        Note over Handler: Abort flow
    end

    Handler-->>Window: Command processed (UI updated)
Loading

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Bundle Report

Changes will increase total bundle size by 144 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 45.76MB 144 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/worker-*.js 3.15MB 3.17MB 17586.03% ⚠️
assets/worker-*.js -3.15MB 17.9kB -99.43%
assets/usePostMessageHandler-*.js 144 bytes 137.81kB 0.1%

Files in assets/usePostMessageHandler-*.js:

  • ./src/app/composables/usePostMessageHandler.ts → Total Size: 5.68kB

Copy link
Copy Markdown
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomanDavydchuk RomanDavydchuk added this pull request to the merge queue Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 114.48 MB 114.41 MB 114.45 MB (σ 0.27) +0.1% +0.0%
memory-rss-baseline 283.04 MB 278.98 MB 289.99 MB (σ 41.20) +1.5% -2.4%

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1269.76 MB 1273.60 MB (σ 10.49) +0.0% -0.3%
docker-image-size-runners 386.00 MB 386.00 MB 392.50 MB (σ 11.06) +0.0% -1.7%

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 186.84 MB 186.52 MB 186.43 MB (σ 0.26) +0.2% +0.2% ⚠️
instance-ai-rss-baseline 344.02 MB 389.20 MB 366.52 MB (σ 22.66) -11.6% -6.1%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

Merged via the queue into master with commit 4869e0a Apr 21, 2026
54 of 55 checks passed
@RomanDavydchuk RomanDavydchuk deleted the node-4714-community-issue-http-request-node-shows-false-credentials branch April 21, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP Request node shows false "credentials not set" warning when using Predefined Credential Type

2 participants