fix(editor): HTTP request node showing warning about credentials not set when they are set#28270
Merged
RomanDavydchuk merged 4 commits intomasterfrom Apr 21, 2026
Conversation
…set when they are set
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Window as External Window/UI
participant Handler as usePostMessageHandler
participant ExecStore as Executions Store
participant CredStore as Credentials Store
participant API as Backend API
Note over Window,API: Execution Data Loading Flow
Window->>Handler: postMessage({ command: "openExecution", executionId })
Handler->>ExecStore: openExecution(executionId)
ExecStore->>API: GET /executions/{id}
API-->>ExecStore: execution data (inc. workflowId)
ExecStore-->>Handler: execution details
alt Execution data found
Handler->>CredStore: NEW: fetchAllCredentialsForWorkflow({ workflowId })
CredStore->>API: NEW: GET /workflows/{id}/credentials
API-->>CredStore: credential metadata list
Handler->>Handler: initialize workflow document store
Note over Handler,CredStore: Node UI resolves credentials from store, clearing warnings
else Execution data null
Note over Handler: Abort flow
end
Handler-->>Window: Command processed (UI updated)
Bundle ReportChanges will increase total bundle size by 144 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
|
…e-shows-false-credentials
Contributor
Performance ComparisonComparing current → latest master → 14-day baseline Memory consumption baseline with starter plan resources
docker-stats
Idle baseline with Instance AI module loaded
How to read this table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you have a workflow with a HTTP request node that has
Authenticationset toPredefined Credential Typeand a valid credential selected, and then go look at the one of the workflow's execution, you'll see a warning about the credentials not being set in that node:but it actually has credentials. The issue is that once you open the execution, the FE does not fetch all of the credentials for the current workflow. This PR fixes that by adding a call to load credentials for the opened workflow
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4714/community-issue-http-request-node-shows-false-credentials-not-set
Closes #27521
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)